From owner-svn-src-head@freebsd.org  Sat Dec 14 19:22:00 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 024931D4F82;
 Sat, 14 Dec 2019 19:21:59 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47Zy8R68vVz4fQS;
 Sat, 14 Dec 2019 19:21:59 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from [192.168.0.5] (unknown [181.52.72.201])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: pfg)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 22155BB82;
 Sat, 14 Dec 2019 19:21:59 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Subject: Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo
To: Ryan Libby <rlibby@gmail.com>, Conrad Meyer <cem@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201912140828.xBE8SAXq027656@repo.freebsd.org>
 <CAHgpiFyQ6+-cbjtwi6NsPkohbQd+6ies0+55g5KtYH9Pog_sTw@mail.gmail.com>
From: Pedro Giffuni <pfg@FreeBSD.org>
Organization: FreeBSD
Message-ID: <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org>
Date: Sat, 14 Dec 2019 14:21:53 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <CAHgpiFyQ6+-cbjtwi6NsPkohbQd+6ies0+55g5KtYH9Pog_sTw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Dec 2019 19:22:00 -0000


On 14/12/2019 13:20, Ryan Libby wrote:
> On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer <cem@freebsd.org> wrote:
>> Author: cem
>> Date: Sat Dec 14 08:28:10 2019
>> New Revision: 355747
>> URL: https://svnweb.freebsd.org/changeset/base/355747
>>
>> Log:
>>    Deprecate sranddev(3) API
>>
>>    It serves no useful purpose and wasn't as popular as its equally meritless
>>    cousin, srandomdev(3).
>>
>> .. (cut unrelated code)
>>
>> Modified: head/include/stdlib.h
>> ==============================================================================
>> --- head/include/stdlib.h       Sat Dec 14 05:21:56 2019        (r355746)
>> +++ head/include/stdlib.h       Sat Dec 14 08:28:10 2019        (r355747)
>> @@ -309,12 +309,17 @@ int        rpmatch(const char *);
>>   void    setprogname(const char *);
>>   int     sradixsort(const unsigned char **, int, const unsigned char *,
>>              unsigned);
>> -void    sranddev(void);
>>   void    srandomdev(void);
>>   long long
>>          strtonum(const char *, long long, long long, const char **);
>>
>>   /* Deprecated interfaces, to be removed. */
>> +static inline void
>> +__attribute__((__deprecated__("sranddev to be removed in FreeBSD 13")))
>> +sranddev(void)
>> +{
>> +}
>> +
> This broke some gcc builds in ci.  It looks like older versions of gcc
> don't like having an argument to deprecated.

FWIW, the msg argument for __deprecated__ appeared in GCC 4.5.

Pedro.