From owner-svn-src-all@freebsd.org Wed Feb 27 03:28:09 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC400150DE51; Wed, 27 Feb 2019 03:28:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5AD33896D7; Wed, 27 Feb 2019 03:28:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id ypt4g0bIHYJbBypt6gGIhk; Tue, 26 Feb 2019 20:28:05 -0700 X-Authority-Analysis: v=2.3 cv=H/OlPNQi c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=CFTnQlWoA9kA:10 a=VxmjJ2MpAAAA:8 a=CgiagczvAAAA:8 a=6I5d2MoRAAAA:8 a=DsloTXpuAAAA:20 a=FNC4LJVLAAAA:20 a=YxBL1-UpAAAA:8 a=W4vuXjRrcZIx3ueIaHIA:9 a=AH9O4czvlS-Q1jQD:21 a=TkqQLVIjEMdcMY2_:21 a=CjuIK1q_8ugA:10 a=7gXAzLPJhVmCkEl4_tsf:22 a=ZydqF0V2MF2Cvey6h_li:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 47FFB1C2; Tue, 26 Feb 2019 19:28:02 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x1R3RgsC062954; Tue, 26 Feb 2019 19:27:42 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x1R3RfXn062807; Tue, 26 Feb 2019 19:27:41 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201902270327.x1R3RfXn062807@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: Fatih Acar , Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, jack@gandi.net, fatih@gandi.net Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common In-Reply-To: Message from Cy Schubert of "Tue, 26 Feb 2019 13:02:53 -0800." <201902262102.x1QL2rIo032528@slippy.cwsent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 26 Feb 2019 19:27:41 -0800 X-CMAE-Envelope: MS4wfPrvZfhVl0WvX5742kozPO5jUFwVtulPpHnavJmhd2c1+m4G508livHCAWkAuBP/lIUt8Ui+QIrlhENQ2nXUcpBkDSjDXV5V36X1x1JD/klQFdsABKTJ BEY8CvhUivm3I6/LRsDO1PzxbOcBPHzWM6xxw835TOreVPbizeuVoW6MZnOkp+a52T1CS+rWoJ1AdPEWmxmUiiCCFQeA2O1/PpmbBgwMtpTb96/JCzAQojvA j+yCn8ahbXWUFKqKfZpOme+3bQki6BiTJXA37zZApLFpJ+RwbYvgyc3r/LHI1XPafGrH/veMfbeIgh5zbTB3YXT2OVCE5tlooSDpPXPI3dF79ED/x2mVX/Ca ik72M55++BmDrK3rB24lhSpcu1hkAA== X-Rspamd-Queue-Id: 5AD33896D7 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.70 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.85)[-0.850,0]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.14)[ip: (-5.86), ipnet: 64.59.128.0/20(-2.65), asn: 6327(-2.08), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[13.134.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 03:28:09 -0000 In message <201902262102.x1QL2rIo032528@slippy.cwsent.com>, Cy Schubert writes: > In message , Fatih Acar > writes: > > This is a multi-part message in MIME format. > > --------------6A54CE5B28D823DCB8C41577 > > Content-Type: text/plain; charset=utf-8 > > Content-Transfer-Encoding: 8bit > > > > On 2/26/19 5:36 PM, Cy Schubert wrote: > > > On February 26, 2019 8:11:31 AM PST, Baptiste Daroussin > > > wrote: > > >> On Tue, Feb 26, 2019 at 05:04:11PM +0100, Baptiste Daroussin wrote: > > >>> On Tue, Feb 26, 2019 at 07:48:27AM -0800, Cy Schubert wrote: > > >>>> On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > > >> wrote: > > >>>>> Author: bapt > > >>>>> Date: Tue Feb 26 08:18:34 2019 > > >>>>> New Revision: 344569 > > >>>>> URL: https://svnweb.freebsd.org/changeset/base/344569 > > >>>>> > > >>>>> Log: > > >>>>> Implement parallel mounting for ZFS filesystem > > >>>>> > > >>>>> It was first implemented on Illumos and then ported to ZoL. > > >>>>> This patch is a port to FreeBSD of the ZoL version. > > >>>>> This patch also includes a fix for a race condition that was > > >> amended > > >>>>> > > >>>>> With such patch Delphix has seen a huge decrease in latency of the > > >>>>> mount phase > > >>>>> (https://github.com/openzfs/openzfs/commit/a3f0e2b569 for > > >> details). > > >>>>> With that current change Gandi has measured improvments that are > > >> on par > > >>>>> with > > >>>>> those reported by Delphix. > > >>>>> > > >>>>> Zol commits incorporated: > > >>>> > > >>> https://github.com/zfsonlinux/zfs/commit/a10d50f999511d304f910852c7825c > 70 > > c9c9e303 > > >>>> > > >>> https://github.com/zfsonlinux/zfs/commit/e63ac16d25fbe991a356489c86d407 > 75 > > 67dfea21 > > >>>>> > > >>>>> Reviewed by: avg, sef > > >>>>> Approved by: avg, sef > > >>>>> Obtained from: ZoL > > >>>>> MFC after: 1 month > > >>>>> Relnotes: yes > > >>>>> Sponsored by: Gandi.net > > >>>>> Differential Revision: https://reviews.freebsd.org/D19098 > > >>>>> > > >>>>> Modified: > > >>>>> head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c > > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h > > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c > > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_impl.h > > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c > > >>>>> > > >>>>> Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c > > >>>> > > >>> ======================================================================= > == > > ===== > [...] > > >>>>> > > >>>> > > >>>> This broke my systems, many filesystems fail to mount causing > > >> nullfs late mounts to fail. No details now until tonight. > > >>>> > > >>>> Suggest we back this out until it is properly tested. > > >>>> > > >>> > > >>> What fails to mount? what message? can you provide Gandi folks more > > >> informations > > >>> so they can fix? > > >>> > > >>> I will revert if we cannot have a quick fix but let s give them a > > >> chance to fix > > >>> first. > > >>> > > >> With the proper email in CC there is a better chance to reach at them > > >> :) > > >> > > >> Best regards, > > >> Bapt > > > > > > Sorry about that. I'm terribly frustrated as this broke my mail gateway, > ha > > ving to fix it using juiceSSH on my phone on the bus. Ssh on the phone make > s > > for a very grumpy Cy. > > > > > > I did bring my personal laptop to work, so I'll try to help out testing t > hi > > s at noon here and maybe look at it more. I'll help out any way I can. > > > > > > > > > > Sorry about all this... > > Could you try the attached patch, it should fix the issue. I don't > > understand how this regression happened, it's not present in ZoL... > > I'll check with Jack who worked on this when he's back from PTO. > > > > Thanks. > > > > -- > > Fatih ACAR > > Gandi > > fatih.acar@gandi.net > > > > --------------6A54CE5B28D823DCB8C41577 > > Content-Type: text/x-patch; > > name="mount.patch" > > Content-Transfer-Encoding: quoted-printable > > Content-Disposition: attachment; > > filename="mount.patch" > > > > Index: cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > = > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > = > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c (revisi > on 3= > > 44590) > > +++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c (workin > g co= > > py) > > @@ -1260,11 +1260,11 @@ > > if (*a =3D=3D '\0') > > return (-1); > > if (*b =3D=3D '\0') > > - return (-1); > > + return (1); > > if (*a =3D=3D '/') > > return (-1); > > if (*b =3D=3D '/') > > - return (-1); > > + return (1); > > return (*a < *b ? -1 : *a > *b); > > } > > =20 > > > > Thanks. This fixes this particular issue. Should we consider committing this? -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.