From owner-freebsd-multimedia@FreeBSD.ORG Fri May 21 07:35:19 2010 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CBE0106566C for ; Fri, 21 May 2010 07:35:19 +0000 (UTC) (envelope-from shoesoft@gmx.net) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id DE9068FC20 for ; Fri, 21 May 2010 07:35:18 +0000 (UTC) Received: (qmail invoked by alias); 21 May 2010 07:35:17 -0000 Received: from 85-127-250-198.dynamic.xdsl-line.inode.at (EHLO walrus.pepperland) [85.127.250.198] by mail.gmx.net (mp069) with SMTP; 21 May 2010 09:35:17 +0200 X-Authenticated: #16703784 X-Provags-ID: V01U2FsdGVkX19jlN982HZj4H0iAFVGdAU24O6buNwBtrYDaPfPfQ SvvVr4dyB5BOBP From: Stefan Ehmann To: freebsd-multimedia@freebsd.org Date: Fri, 21 May 2010 09:35:16 +0200 User-Agent: KMail/1.13.3 (FreeBSD/8.0-RELEASE; KDE/4.4.3; i386; ; ) References: <20100513233437.GR27722@danbala.tuwien.ac.at> <201005202145.31750.shoesoft@gmx.net> <20100520215235.9960d8be.torfinn.ingolfsen@broadpark.no> In-Reply-To: <20100520215235.9960d8be.torfinn.ingolfsen@broadpark.no> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005210935.16291.shoesoft@gmx.net> X-Y-GMX-Trusted: 0 Cc: Subject: Re: multimedia/pvr250 port doesn't compile on FreeBSD 8 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2010 07:35:19 -0000 On Thursday 20 May 2010 21:52:35 Torfinn Ingolfsen wrote: ... > > > Reading through the thread, I am left with one question: > > > Where should I add this line: > > > DRIVER_MODULE(iicbb, cxm_iic, iicbb_driver, iicbb_devclass, 0, 0); > > > > > > I tried adding it to cxm.c (below the other DRIVER_MODULE line) but > > > that didn't help. and /usr/src/sys/dev/iicbus/iicbb.c already contains > > > that line. > > > > I put it in cxm_i2c.c for pvrxxx. > > Hmm, cxm_i2c.c already contains that line. > root@kg-fil# grep DRIVER ./work/dev/cxm/cxm_i2c.c > DRIVER_MODULE(cxm_iic, cxm, cxm_iic_driver, cxm_iic_devclass, 0, 0); > root@kg-fil# uname -a > FreeBSD kg-fil.kg4.no 8.0-STABLE FreeBSD 8.0-STABLE #3: Thu Dec 31 00:34:23 > CET 2009 root@kg-fil.kg4.no:/usr/obj/usr/src/sys/GENERIC amd64 > > Do I also need to "hack" minor? These lines are not the same. You need them both: --- pvrxxx.orig/dev/cxm/cxm_i2c.c 2009-12-05 13:31:54.000000000 +0100 +++ pvrxxx/work/dev/cxm/cxm_i2c.c 2009-12-01 08:52:29.000000000 +0100 @@ -131,6 +131,7 @@ #endif MODULE_VERSION(cxm_iic, 1); DRIVER_MODULE(cxm_iic, cxm, cxm_iic_driver, cxm_iic_devclass, 0, 0); +DRIVER_MODULE(iicbb, cxm_iic, iicbb_driver, iicbb_devclass, 0, 0); /*