From owner-freebsd-geom@FreeBSD.ORG Thu Apr 5 22:10:06 2012 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 41B6A106566B for ; Thu, 5 Apr 2012 22:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 12F1D8FC0A for ; Thu, 5 Apr 2012 22:10:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q35MA5Ow065890 for ; Thu, 5 Apr 2012 22:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q35MA5gt065889; Thu, 5 Apr 2012 22:10:05 GMT (envelope-from gnats) Date: Thu, 5 Apr 2012 22:10:05 GMT Message-Id: <201204052210.q35MA5gt065889@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Bengt Ahlgren Cc: Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bengt Ahlgren List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2012 22:10:06 -0000 The following reply was made to PR bin/165789; it has been noted by GNATS. From: Bengt Ahlgren To: bug-followup@freebsd.org, jguojun@sbcglobal.net Cc: ae@freebsd.org Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! Date: Fri, 6 Apr 2012 00:05:39 +0200 I got the same message on my system newly upgraded to 8.3-RC1 (r232744). I have not touched the partitions since installing some time ago. I definitely did not get this message from bsdlabel before. It also was bsdlabel that created the partitions, but I don't remember from which OS version. I want to point out that the "c" partition does indeed cover the whole slice. See here: # gpart show ada1 => 63 1953525105 ada1 MBR (931G) 63 62926542 1 freebsd [active] (30G) 62926605 62926605 2 freebsd (30G) 125853210 1827671958 3 freebsd (871G) # gpart show ada1s1 => 0 62926542 ada1s1 BSD (30G) 0 16 - free - (8.0k) 16 2097152 1 freebsd-ufs (1.0G) 2097168 8388608 2 freebsd-swap (4.0G) 10485776 4194304 4 freebsd-ufs (2.0G) 14680080 48246462 5 freebsd-ufs (23G) # bsdlabel ada1s1 # /dev/ada1s1: 8 partitions: # size offset fstype [fsize bsize bps/cpg] a: 2097152 16 4.2BSD 0 0 0 b: 8388608 2097168 swap c: 62926542 0 unused 0 0 # "raw" part, don't edit d: 4194304 10485776 4.2BSD 0 0 0 e: 48246462 14680080 4.2BSD 0 0 0 bsdlabel: partition c doesn't cover the whole unit! bsdlabel: An incorrect partition c may cause problems for standard system utilities I added a printout of the value bsdlabel compares with: bsdlabel: partition c doesn't cover the whole unit! 1953525168 This number corresponds to the size of the whole disk, not the size of the slice, so lp->d_secperunit is not the right variable to use, or is incorrectly set. Finally, I stepped back to r220455 (in stable/8). That version of bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is causing, or making visible, this problem. Bengt