From owner-cvs-all@FreeBSD.ORG Fri Oct 19 17:18:42 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00C0016A41B; Fri, 19 Oct 2007 17:18:42 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.177]) by mx1.freebsd.org (Postfix) with ESMTP id 0EB7B13C442; Fri, 19 Oct 2007 17:18:27 +0000 (UTC) (envelope-from max@love2party.net) Received: from amd64.laiers.local (dslb-088-066-029-194.pools.arcor-ip.net [88.66.29.194]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1IivUQ1Tyf-0008Ki; Fri, 19 Oct 2007 19:18:26 +0200 From: Max Laier Organization: FreeBSD To: Robert Watson Date: Fri, 19 Oct 2007 19:18:08 +0200 User-Agent: KMail/1.9.7 References: <200710182142.l9ILgsGd015588@repoman.freebsd.org> <20071019175247.C83542@fledge.watson.org> In-Reply-To: <20071019175247.C83542@fledge.watson.org> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6125884.gSIXVcmuoo"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710191918.25235.max@love2party.net> X-Provags-ID: V01U2FsdGVkX19erHRu2F9ZpBPo6pTqC7VaKGm7OUv9U1klnPH d2gKNIYOwf8HmGfx/W4qTjwIPyGqdd+2JbFNhmK+SUDtdyCgFO FPeQZPBT7jT1RelehnhUeOr0PxaKvBnkL2/EABTI2w= Cc: Darren Reed , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 17:18:42 -0000 --nextPart6125884.gSIXVcmuoo Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 19 October 2007, Robert Watson wrote: > On Thu, 18 Oct 2007, Darren Reed wrote: > > darrenr 2007-10-18 21:42:54 UTC > > > > FreeBSD src repository > > > > src/sys/contrib/ipfilter/netinet - Imported sources > > Update of /home/ncvs/src/sys/contrib/ipfilter/netinet > > In directory repoman.freebsd.org:/tmp/cvs-serv15525 > > > > Log Message: > > Import IPFilter 4.1.28 > > > > Status: > > > > Vendor Tag: DARRENR > > Release Tags: v4-1-28 > > I didn't see a reply from you on the thread on current@ regarding the > ipfilter panics, so I'll ask here: does this import resolve the panics > that users are experiencing with ipfilter on 7.x/8.x when INVARIANTS is > enabled? According to my reading, the crashes described in=20 http://lists.freebsd.org/pipermail/freebsd-current/2007-October/078484.html= =20 are still present due to the following code in ip_fil_freebsd.c line=20 490ff: READ_ENTER(&ipf_global); error =3D fr_ioctlswitch(unit, data, cmd, mode, p->p_uid, p); Where fr_ioctlswitch() does the actual copyin/copyout and READ_ENTER=20 acquires a rwlock(9) which can't sleep. This is an improvement over the=20 previous attempt to sleep in the transmission path (due to useing sx(9)=20 locks), but it is still not correct and fragile even without INVARIANTS. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart6125884.gSIXVcmuoo Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHGObhXyyEoT62BG0RAl46AJ9UhNkiUA8jFnyDEhK6t/fA57vBIQCfZKnF 40qKlVxtWo6TxMO719MS30Y= =LOWw -----END PGP SIGNATURE----- --nextPart6125884.gSIXVcmuoo--