From owner-freebsd-current@FreeBSD.ORG  Sat Aug  2 16:14:21 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 05AB037B401
	for <freebsd-current@FreeBSD.ORG>;
	Sat,  2 Aug 2003 16:14:21 -0700 (PDT)
Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4666643FB1
	for <freebsd-current@FreeBSD.ORG>;
	Sat,  2 Aug 2003 16:14:20 -0700 (PDT)	(envelope-from drosih@rpi.edu)
Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47])
	by smtp2.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h72NEICx032689;
	Sat, 2 Aug 2003 19:14:18 -0400
Mime-Version: 1.0
X-Sender: drosih@mail.rpi.edu
Message-Id: <p052106b5bb51f576bd66@[128.113.24.47]>
In-Reply-To: <20030802003845.GE73426@trudy.torrini.home>
References: <20030802000332.GD73426@trudy.torrini.home>
 <20030802003845.GE73426@trudy.torrini.home>
Date: Sat, 2 Aug 2003 19:14:17 -0400
To: Riccardo Torrini <riccardo@torrini.org>,
	freebsd-current@FreeBSD.ORG
From: Garance A Drosihn <drosih@rpi.edu>
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
X-Scanned-By: CanIt (www . canit . ca)
Subject: Re: newsyslog problems with -C
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Aug 2003 23:14:21 -0000

At 2:38 AM +0200 8/2/03, Riccardo Torrini wrote:
>
>Looking into sources I found two close(fd).
>Here is the patch:
>
>-----8<-----[ patch ]-----8<-----
># diff -u newsyslog.c.orig newsyslog.c
>--- newsyslog.c.orig    Sun May 25 18:46:13 2003
>+++ newsyslog.c Sat Aug  2 02:28:50 2003
>@@ -1764,7 +1764,6 @@
>			failed = fchown(fd, ent->uid, ent->gid);
>			if (failed)
>				err(1, "can't fchown temp file %s", tempfile);
>-				(void) close(fd);
>		}
>	}
>-----8<-----[ patch ]-----8<-----

I committed this in -current.  I'll MFC it into -stable in a
few days.  Thanks!

-- 
Garance Alistair Drosehn            =   gad@gilead.netel.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu