From nobody Wed May 25 20:31:12 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D68BA1B4DF21 for ; Wed, 25 May 2022 20:31:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L7jQ90CWQz3jt6 for ; Wed, 25 May 2022 20:31:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9845B1FFC3 for ; Wed, 25 May 2022 20:31:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24PKVCsW049157 for ; Wed, 25 May 2022 20:31:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24PKVCRx049155 for bugs@FreeBSD.org; Wed, 25 May 2022 20:31:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 239250] need to define limits on unix socket control messages Date: Wed, 25 May 2022 20:31:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653510673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xEAi9BLJ1DX8DjbMTSiu5DDEbvf09YD25bCHd/qgI9s=; b=rZe8jhVhOftIOQQH4Xt20UmRrt8j8PDbR1wkQ9S+xCoQfOqXDZM5yeRd44Un9OGF6CiUlO gDKwTANOIaUw/ibTO7mbN0HaIHqaV89ZbNs6e5aU5UZ5QjI+Xf3c466VFvBBVAY0g0saN8 cIKw2Kz+XWSzRX9h96HGLIOCZwECXtRKFBg5F0zeZ6pd1Qw23SRXUhs/+rUvLGZIUj+YCf ikB0pLD2PGgbx1d2J5eG1yaKMBhYFRpnoi/JRLrqpzD0jmiR5VQdgFbKf8HVq4fj6uRwiw YTYJV+lPH2QJ5L5wkk2S88ycEGUCE9ESJxnwOsgNQLhnmlK+xnvyEpmDIStstw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653510673; a=rsa-sha256; cv=none; b=k4EvAeE7aM37s/noJzykHDqII0AvktMnfQs77edzkxLHkuuOyj0DtThJHpTRjDH/JDPNLc XyEP7O7E77iqy6Q8L/0jpJHXnojAooil/6mViy+5QsrSm2xmkNB0jbSnoLxxZok7jqPnbH rTTfd0ycj93ilY1E8fghcQ0+1E5/2R1RuQj8e4/NBzHhc/OI9r0vfbUnQ+dhhF3DMMGUeB xqxYlNuInN9muo2lcktd85rREqGZ7GQVvqwz2k1NHB5Hp3Q/asyXPDyh+M2CW92+Os6saK Sp3KRy02KvKks/gABQ8vldsUAbHE2HY9i1csgYX2OKpw5J8FucoSWj9M3p2dqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239250 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D23402c83f4fc2db45f0435ed106791828= a6522df commit 23402c83f4fc2db45f0435ed106791828a6522df Author: Gleb Smirnoff AuthorDate: 2022-05-25 20:28:40 +0000 Commit: Gleb Smirnoff CommitDate: 2022-05-25 20:28:40 +0000 tests/unix_passfd: sending many and too many SCM_RIGHTS o Exercise bounds checking when sending large set of file descriptors, that can't fit into single control mbuf. o Exercise resource limits checks when receiving a large sets. o Check that socket isn't left in a completely stuck state when we can't receive SCM_RIGHTS due to limits. Current SOCK_STREAM socket would free the control, but leave the data in. This seems to be a legit behavior for a stream socket, as we don't want holes in the data. PR: 239250 Reviewed by: markj Differential revision: https://reviews.freebsd.org/D35315 tests/sys/kern/unix_passfd_test.c | 69 +++++++++++++++++++++++++++++++++++= +++- 1 file changed, 68 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=