Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 May 2019 21:04:57 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Carlo Strub <cs@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r502285 - head/www/otrs
Message-ID:  <20190522210457.GA33127@FreeBSD.org>
In-Reply-To: <201905222049.x4MKn3lU076208@repo.freebsd.org>
References:  <201905222049.x4MKn3lU076208@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 22, 2019 at 08:49:03PM +0000, Carlo Strub wrote:
> New Revision: 502285
> URL: https://svnweb.freebsd.org/changeset/ports/502285
> 
> Log:
>   Add missing dependendies.

This commit message sucks.  Not just it does not accurately reflect the
changes made -- it does not explain the rationale behind them.

> Modified: head/www/otrs/Makefile
> @@ -56,7 +60,7 @@ SHEBANG_FILES=	bin/cgi-bin/*.pl bin/cgi-bin/app.psgi b
>  		scripts/tools/*.pl scripts/*.pl
>  
>  OPTIONS_DEFINE=		MYSQL PGSQL REPORTS SMTP POP3 IMAP LDAP PDF \
> -			GNUPG APACHE SSL XML
> +			GNUPG APACHE SSL
>  OPTIONS_DEFAULT=	MYSQL REPORTS SMTP POP3 IMAP PDF ASPELL APACHE \
>  			SSL
>  OPTIONS_RADIO=		SPELL
> @@ -125,10 +129,6 @@ ISPELL_RUN_DEPENDS=	ispell:textproc/aspell-ispell
>  ASPELL_RUN_DEPENDS=	aspell:textproc/aspell
>  
>  GNUPG_RUN_DEPENDS=	gpg:security/gnupg1
> -
> -XML_RUN_DEPENDS=	p5-XML-Parser>=0:textproc/p5-XML-Parser \
> -			p5-XML-LibXML>=0:textproc/p5-XML-LibXML \
> -			p5-XML-LibXSLT>=0:textproc/p5-XML-LibXSLT

So basically you've removed the XML option, rather than making it
on by default.  Why?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190522210457.GA33127>