From owner-cvs-all  Thu Oct 17 18: 9:50 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DC1C137B401; Thu, 17 Oct 2002 18:09:48 -0700 (PDT)
Received: from pirzyk.org (dsl-65-184-181-29.telocity.com [65.184.181.29])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6EFDF43E3B; Thu, 17 Oct 2002 18:09:48 -0700 (PDT)
	(envelope-from pirzyk@pirzyk.org)
Received: from zephyr.pirzyk.org (localhost [127.0.0.1])
	by pirzyk.org (8.12.3/8.12.3) with ESMTP id g9I17Baw006447;
	Thu, 17 Oct 2002 18:07:11 -0700 (PDT)
	(envelope-from pirzyk@zephyr.pirzyk.org)
Received: (from pirzyk@localhost)
	by zephyr.pirzyk.org (8.12.3/8.12.3/Submit) id g9I17BXN006446;
	Thu, 17 Oct 2002 18:07:11 -0700 (PDT)
Date: Thu, 17 Oct 2002 18:07:11 -0700 (PDT)
From: Jim Pirzyk <pirzyk@pirzyk.org>
Message-Id: <200210180107.g9I17BXN006446@zephyr.pirzyk.org>
To: doconnor@gsoft.com.au, pirzyk@pirzyk.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c
Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG,
	pirzyk@FreeBSD.ORG
In-Reply-To: <1034902706.85350.21.camel@chowder.gsoft.com.au>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> On Fri, 2002-10-18 at 10:08, Jim Pirzyk wrote:
> > >   Changed the scsi mode command to use 10 bytes scsi commands instead
> > >   of the 6 byte ones.  This helps with using a IDE cdrom behind a USB
> > >   interface.
> > >   
> > >   PR: kern/43885
> > >   
> > >   Revision  Changes    Path
> > >   1.65      +11 -9     src/sys/cam/scsi/scsi_cd.c
> > 
> > forgot:
> > 
> > MFC-After: 1 month
>
> Shouldn't this be done via hints?

How would that be done?  If there is a sysctl knob to change the
behavior, then I could see it working, but not with the change
that I made.  

> As someone else pointed out it potentially screws up older SCSI CDROM
> drives.

Looking at all the other scsi commands in the file, it was the only one
at 6 bytes, the rest were at 10 or 12, that I could find.

- JimP

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message