From owner-cvs-all  Sun Apr 19 22:06:20 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id WAA24923
          for cvs-all-outgoing; Sun, 19 Apr 1998 22:06:20 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA24723;
          Mon, 20 Apr 1998 05:05:34 GMT
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id PAA05579;
	Mon, 20 Apr 1998 15:04:24 +1000
Date: Mon, 20 Apr 1998 15:04:24 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199804200504.PAA05579@godzilla.zeta.org.au>
To: brian@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/ppp bundle.c fsm.c id.c ipcp.c lcp.c log.h lqr.c modem.c prompt.h sig.c slcompress.c timer.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>brian       1998/04/19 16:09:15 PDT
>
>  Modified files:        (Branch: MP)
>    usr.sbin/ppp         bundle.c fsm.c id.c ipcp.c lcp.c log.h 
>                         lqr.c modem.c prompt.h sig.c slcompress.c 
>                         timer.c 
>  Log:
>  o Use __attribute__ (#ifdef __GNUC__) to type-check
>    LogPrintf() and prompt_Printf(), and fix the bits
>    identified as being wrong as a result.

Ifdefing the use of __attribute__ is unnecessary because <sys/cdefs.h>
already defines away __attribute__ (#if __GNUC__ < 2).

Defining away __attribute__ is not quite right.  Cases where __attribute__
is used to change the semantics just become wrong if __attribute__ is
defined away.  We currently avoid this problem by only using __attribute__
for non-semantic things, but I want to use it to define nonstandard types
(see <stdio.h> and the error output for building ncal as part of
`make world').

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message