From owner-cvs-all@FreeBSD.ORG Fri Aug 4 08:02:09 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7688216A4DA; Fri, 4 Aug 2006 08:02:09 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1162543D49; Fri, 4 Aug 2006 08:02:07 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k74826NH013662; Fri, 4 Aug 2006 12:02:06 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k74825x6013661; Fri, 4 Aug 2006 12:02:05 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 12:02:05 +0400 From: Yar Tikhiy To: Stefan Farfeleder Message-ID: <20060804080205.GV97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> <20060804075230.GD89735@wombat.fafoe.narf.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804075230.GD89735@wombat.fafoe.narf.at> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 08:02:09 -0000 On Fri, Aug 04, 2006 at 09:52:31AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > > sweeps separate from actual code changes even if they are tiny. > > > > Changing style(9) shouldn't alter the binary code produced, and > > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > > Of course, changing line numbers will affect debug info, but the > > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > > if_em.o with its former version to make sure no code changed. > > > > > > It will produce different code if __LINE__ is used. > > > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > > Fortunately, they are not widely used in src/, AFAIK. > > Not directly, but through all kinds of assertion macros. At least, KASSERT() doesn't use __LINE__. No doubt there may be others that do. -- Yar