From owner-cvs-all@FreeBSD.ORG Wed Nov 16 14:12:49 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE3CC16A41F; Wed, 16 Nov 2005 14:12:49 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C9DF43D46; Wed, 16 Nov 2005 14:12:48 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id E997450F93; Wed, 16 Nov 2005 15:12:46 +0100 (CET) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id AF7BA50B83; Wed, 16 Nov 2005 15:12:39 +0100 (CET) Date: Wed, 16 Nov 2005 15:12:23 +0100 From: Pawel Jakub Dawidek To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20051116141223.GB7992@garage.freebsd.pl> References: <200511161103.jAGB30d4062758@repoman.freebsd.org> <20051116112419.GA1363@nagual.pp.ru> <20051116115900.GA7992@garage.freebsd.pl> <20051116124143.GA2104@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mojUlQ0s9EVzWg2t" Content-Disposition: inline In-Reply-To: <20051116124143.GA2104@nagual.pp.ru> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Subject: Re: cvs commit: src/usr.bin/pkill pkill.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2005 14:12:50 -0000 --mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 16, 2005 at 03:41:43PM +0300, Andrey Chernov wrote: +> On Wed, Nov 16, 2005 at 12:59:00PM +0100, Pawel Jakub Dawidek wrote: +> > Let's say you call 'pkill sleep'. First it creates list of the matching +> > processes and when the list is done, it starts killing processes from +> > the list. When there is a race, so that process was inserted into the +> > list, but disappeared before killing, pkill(1) will quit with an error. +> > Which is bogus: there were 8 sleep processes, the 5th one disappeared, +> > so first 4 was killed, last 3 are still alive and pkill(1) returned an +> > error. +>=20 +> Well, my initial statement will be modified slightly. +>=20 +> 1) For SIGKILL, pkill should ignore disappeared precesses, as NetBSD doe= s. +> 2) For any other signal, it should issue _warning_ and not error & stop. I can't agree here. You know, that running the same pkill command a bit later (few miliseconds?) will not give you the warning? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --mojUlQ0s9EVzWg2t Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDez5HForvXbEpPzQRAsdoAKCodHpxN50hwjtAVFH6Ba/yguGbgQCfc/vx /RcTIWe0S4uLcqTEsUMEB84= =QD3y -----END PGP SIGNATURE----- --mojUlQ0s9EVzWg2t--