Date: Fri, 12 May 2023 16:51:46 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on Message-ID: <bug-254596-7501-6oZBabTG6W@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-254596-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-254596-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254596 --- Comment #9 from paul vixie <paul@redbarn.org> --- (In reply to Naman Sood from comment #7) i've now tested this patch and it does what i need. the LRO option remains = on for the physical interface and for the vlan subinterfaces which are not add= ed to a bridge. i did not performance-test the physical interface or other subinterfaces to see what impact LRO was having, but input coalescence is a theoretical boon and i'm glad to not have to turn off LRO on the physical interface in order to protect the bridge members from having LRO turned on inappropriately. the main motivation is to avoid input coalescence on the bridge member, sin= ce the other bridge members are tap(4) interfaces each belonging to a bhyve gu= est (where the interface shows up as a vtnet(4) interface.) input coalescence in this case is not just a performance problem it damages the input flow and m= akes the bhyve guest unusable. i was working around this by turning off LRO on t= he physical interface but this is a price too high: bhyve guests whose bridge = is connected not by a physical interface but by a vlan subinterface must "just work". i am attaching a second patch, this time in "git format-patch" format, since this was requested. it looks the same to me. can this patch be reviewed for inclusion in 13.3 and also pulled into the 13.2 release in the next mainten= ance patch? --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-254596-7501-6oZBabTG6W>