Date: Wed, 18 Jun 2008 13:40:46 +0200 (CEST) From: Stefan Sperling <stsp@stsp.name> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/124712: x11-themes/clearlooks-themes does not build Message-ID: <200806181140.m5IBekBv040650@ted.stsp.name> Resent-Message-ID: <200806181220.m5ICK5Yv067742@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 124712
>Category: ports
>Synopsis: x11-themes/clearlooks-themes does not build
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 18 12:20:04 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Stefan Sperling
>Release: FreeBSD 7.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD ted.stsp.name 7.0-RELEASE FreeBSD 7.0-RELEASE #2: Sat Mar 29 23:54:21 CET 2008 stsp@ted.stsp.name:/usr/obj/home/stsp/src/freebsd-7.0/sys/TED i386
>Description:
It seems that an attempt to fix a build failure of this port
did not really fix it.
When trying to install this port, is errors out with:
Gnome/gtk-engine users should use /usr/ports/x11-themes/clearlooks-themes instead
*** Error code 1
This is because the Makefile of the master port (x11-themes/clearlooks)
uses ${PORTNAME} to determine which port it is building:
A recent commit changed the PORTNAME of x11-themes/clearlooks-themes
from "clearlooks-themes" to just "clearlooks", which makes the Makefile
think the master port is being built, even though the sub-port is being built.
----------------------------
revision 1.3
date: 2008/04/22 08:33:35; author: miwi; state: Exp; lines: +2 -1
- Fix build after xorg cleanup
Submitted by: pointyhat
$ cvs diff -r1.2 -r1.3 Makefile
Index: Makefile
===================================================================
RCS file: /usr/ncvs/ports/x11-themes/clearlooks-themes/Makefile,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- Makefile 13 Apr 2005 16:50:05 -0000 1.2
+++ Makefile 22 Apr 2008 08:33:35 -0000 1.3
@@ -2,10 +2,11 @@
# Date created: 2005-04-12
# Whom: Michael Johnson <ahze@FreeBSD.org>
#
-# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.2 2005/04/13 16:50:05 ahze Exp $
+# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.3 2008/04/22 08:33:35 miwi Exp $
#
-PORTNAME= clearlooks-themes
+PORTNAME= clearlooks
+PKGNAMESUFFIX+= -themes
COMMENT= Clearlooks themes with the engine coming from gtk-engines2
Whatever this commit tried to fix exactly (sadly, the log message
does not say), the fix is clearly wrong.
>How-To-Repeat:
cd /usr/ports/x11-themes/clearlooks-themes && make
>Fix:
This patch makes x11-themes/clearlooks-themes build again.
I have no idea whether this has any effect on the original
problem which the commit tried to fix, because I don't have
any information on what the original problem was beyond
the terse hint provided in the commit's log message.
Apart from changing the PORTNAME back to "clearlooks-themes",
it also fixes a problem with the distfile's name -- if DISTNAME
is left at its default value, the port cannot build because
it will assume a distname that does not match what's in the
master port's distinfo file.
Index: Makefile
===================================================================
RCS file: /usr/ncvs/ports/x11-themes/clearlooks-themes/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile 22 Apr 2008 08:33:35 -0000 1.3
+++ Makefile 18 Jun 2008 11:19:22 -0000
@@ -2,11 +2,13 @@
# Date created: 2005-04-12
# Whom: Michael Johnson <ahze@FreeBSD.org>
#
-# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.3 2008/04/22 08:33:35 miwi Exp $
+# $FreeBSD: ports/x11-themes/clearlooks-themes/Makefile,v 1.2 2005/04/13 16:50:05 ahze Exp $
#
-PORTNAME= clearlooks
-PKGNAMESUFFIX+= -themes
+PORTNAME= clearlooks-themes
+# XXX: PORTVERSION needs to be kept in sync with the master port.
+PORTVERSION= 0.6.2
+DISTNAME= clearlooks-${PORTVERSION}
COMMENT= Clearlooks themes with the engine coming from gtk-engines2
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806181140.m5IBekBv040650>