From owner-freebsd-ports@FreeBSD.ORG Tue Oct 5 14:47:07 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C53831065673 for ; Tue, 5 Oct 2010 14:47:07 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 51FDD8FC1B for ; Tue, 5 Oct 2010 14:47:06 +0000 (UTC) Received: by ewy22 with SMTP id 22so2987190ewy.13 for ; Tue, 05 Oct 2010 07:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :organization:user-agent:mime-version:to:subject:x-enigmail-version :content-type:content-transfer-encoding; bh=82LTQadS0DPqVftcXQSMRoiaBeowfzEmDbtHb2crw4w=; b=qis3+RCsOrYyGDJ6LZhUGzXAgHrxDCZLg8qH/8lIjAWL/P05XibDPIV/Z6xeWqd+h2 U4q/Ue65R57ov94GRq7gl4aTVv4T8p/v2ZOtX2Lx94N+ZTgZVJOV/Q9qaQ4kxXoWkWwv zVl8lrTLmhovvTfMWF6iu1VuaXHxcxu5KAg7s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:organization:user-agent:mime-version:to :subject:x-enigmail-version:content-type:content-transfer-encoding; b=R9ei921v0ODBrMlEfsjBlarWqJeNPwJ2NXxrl66I0PE9YKp/eFV59Jb7FCy3Qd7UHT XShpQ8f1WEFdZ/srhv6UAzwJAl0I5zxQR0SblU3pdg5MfqZADksHmWNiwr+Iyms56rEJ 6IfO4coTOg5/exL86RH1s40F/HgDaQmLURlQg= Received: by 10.103.231.4 with SMTP id i4mr3780722mur.68.1286290023912; Tue, 05 Oct 2010 07:47:03 -0700 (PDT) Received: from centel.dataix.local ([99.181.144.115]) by mx.google.com with ESMTPS id j22sm2231995vcr.31.2010.10.05.07.47.01 (version=SSLv3 cipher=RC4-MD5); Tue, 05 Oct 2010 07:47:02 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4CAB3A64.4080709@DataIX.net> Date: Tue, 05 Oct 2010 10:47:00 -0400 From: jhell Organization: http://www.DataIX.net User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.9) Gecko/20100917 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: gordon@freebsd.org, FreeBSD Ports X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: devel/p4d/Makefile X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2010 14:47:07 -0000 Hi Gordon, I have just upgraded my p4d install and have found the following inconsistency in the Makefile: ${CAT} pkg-message pkg-message at this point cannot be found and it would be better if this referred to the ports directory and the portname /pkg-message instead. I might also suggest that instead of using touch(1) chown(1) chmod(1) to create entries in the filesystem for the p4d.log that you use install(1) instead as that allows you to achieve all three steps listed above in one command like so. install -S -o p4admin -g p4admin -m 640 /dev/null /var/log/p4d.log And of course this might need/involve some checking to see if the users log file already exists as we would not want to overwrite that by the above command but nor do we want to blindly chmod(1) the file either which is also done in the Makefile already. Regards, -- jhell,v