From owner-freebsd-current@freebsd.org Wed Apr 14 15:10:19 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CEB005DCE2C for ; Wed, 14 Apr 2021 15:10:19 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FL5WH5PFwz3N3S for ; Wed, 14 Apr 2021 15:10:19 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id B91395DCD2A; Wed, 14 Apr 2021 15:10:19 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B8C745DCD96; Wed, 14 Apr 2021 15:10:19 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FL5WH2LWYz3N76; Wed, 14 Apr 2021 15:10:18 +0000 (UTC) (envelope-from avg@FreeBSD.org) X-Originating-IP: 195.64.148.76 Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B7C531C0009; Wed, 14 Apr 2021 15:10:16 +0000 (UTC) To: Mark Johnston Cc: freebsd-stable List , FreeBSD Current References: <0606571f-fec0-c7ad-98e8-a0b8554918e2@FreeBSD.org> <23d370fa-41db-a89b-03fd-e45deb874aed@FreeBSD.org> From: Andriy Gapon Subject: Re: stable/13, vm page counts do not add up Message-ID: <9b1aa260-f54a-dc7a-bf19-1d83a49a01ac@FreeBSD.org> Date: Wed, 14 Apr 2021 18:10:15 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4FL5WH2LWYz3N76 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 15:10:19 -0000 On 14/04/2021 16:32, Mark Johnston wrote: > On Wed, Apr 14, 2021 at 02:21:44PM +0300, Andriy Gapon wrote: >> On 14/04/2021 00:18, Mark Johnston wrote: >>> fbt::vm_page_unwire:entry >>> /args[0]->oflags & 0x4/ >>> { >>> @unwire[stack()] = count(); >>> } >> >> Unrelated report, dtrace complains about this probe on my stable/13 system: >> failed to resolve translated type for args[0] >> >> And I do not have any idea why... > > There was a regression, see PR 253440. I think you have the fix > already, but perhaps not. Could you show output from > "dtrace -lv -n fbt::vm_page_unwire:entry"? dtrace -lv -n fbt::vm_page_unwire:entry ID PROVIDER MODULE FUNCTION NAME 54323 fbt kernel vm_page_unwire entry Probe Description Attributes Identifier Names: Private Data Semantics: Private Dependency Class: Unknown Argument Attributes Identifier Names: Private Data Semantics: Private Dependency Class: ISA Argument Types args[0]: (unknown) args[1]: (unknown) It seems that I should have the fix, but somehow I still have the problem. I've been doing NO_CLEAN builds for a long while, so maybe some stale file didn't get re-created... It looks that dt_lex.c under /usr/obj is rather dated. ... I've removed that file and rebuilt libdtrace and everything is okay now. Thank you. >> From ctfdump: >> [27290] FUNC (vm_page_unwire) returns: 38 args: (1463, 3) >> >> <1463> TYPEDEF vm_page_t refers to 778 >> <778> POINTER (anon) refers to 3575 >> <3575> STRUCT vm_page (104 bytes) >> plinks type=3563 off=0 >> listq type=3558 off=128 >> object type=3564 off=256 >> pindex type=3565 off=320 >> phys_addr type=42 off=384 >> md type=3571 off=448 >> ref_count type=31 off=640 >> busy_lock type=31 off=672 >> a type=3573 off=704 >> order type=3 off=736 >> pool type=3 off=744 >> flags type=3 off=752 >> oflags type=3 off=760 >> psind type=2167 off=768 >> segind type=2167 off=776 >> valid type=3574 off=784 >> dirty type=3574 off=792 >> >> -- >> Andriy Gapon -- Andriy Gapon