From owner-cvs-all Sun Nov 28 17:20: 1 1999 Delivered-To: cvs-all@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 18733153F5; Sun, 28 Nov 1999 17:19:54 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.3/8.9.1) id RAA47318; Sun, 28 Nov 1999 17:19:53 -0800 (PST) (envelope-from dillon) Date: Sun, 28 Nov 1999 17:19:53 -0800 (PST) From: Matthew Dillon Message-Id: <199911290119.RAA47318@apollo.backplane.com> To: Kris Kennaway Cc: Dan Moschuk , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/conf files.i386 src/sys/kern kern_fork.c src/sys/libkern arc4random.c src/sys/sys libkern.h References: Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk : :Reviewed and Not Approved by: kris. You're using a weak seeding mechanism :and a handmade arc4 implementation which is not as good as the one we :already have in libc. : :IMO, if you ask for a review and get objections, you should wait to :address them before actually committing..otherwise, what's the point? : :> Revision Changes Path :> 1.282 +2 -1 src/sys/i386/conf/files.i386 :> 1.70 +6 -3 src/sys/kern/kern_fork.c :> 1.19 +2 -1 src/sys/sys/libkern.h : :Plus. you seem to have failed to commit the arc4.c :-) : :Kris : :---- I sure hope the algorithm does not recycle PIDs for a reasonable amount of time, or you may end up with a race in scripts that kill processes via their /var/run pid's. You know: kill -HUP, then kill -9 sequences and such. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message