From owner-freebsd-arch@FreeBSD.ORG Sat Aug 2 10:14:01 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFD8337B401 for ; Sat, 2 Aug 2003 10:14:01 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8080943F75 for ; Sat, 2 Aug 2003 10:13:58 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h72HDs0U038219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 2 Aug 2003 20:13:54 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h72HDrMZ038214; Sat, 2 Aug 2003 20:13:53 +0300 (EEST) (envelope-from ru) Date: Sat, 2 Aug 2003 20:13:52 +0300 From: Ruslan Ermilov To: Faried Nawaz Message-ID: <20030802171352.GA36129@sunbay.com> References: <20030730212049.GI33188@sunbay.com> <20030730162320.A66578@FreeBSD.org> <20030730212744.GJ33188@sunbay.com> <20030730163705.A68092@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i cc: arch@FreeBSD.org Subject: Re: make -U X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Aug 2003 17:14:02 -0000 --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [ Moved to -arch ] > From the message in freebsd-hackers which first introduced > this patch: >=20 > - Date: Tue, 29 Jul 2003 09:09:17 -0700 > - From: Faried Nawaz > - Subject: patch to add make -U >=20 > While working around a port issue (ports/55013), I discovered > that make couldn't unset variables using make -U. I've written > a small patch that adds -U functionality, but I haven't tested > it extensively. >=20 > http://web.nilpotent.org/tmp/make.diff.bz2 (~ 3KB unpacked) > against yesterday's -CURRENT code. >=20 The patch looks sane. > A simple Makefile I used to test it: >=20 > -- cut here -- > FOO =3D bar >=20 > .ifdef FOO > SAY =3D y > .else > SAY =3D n > .endif >=20 > all: > echo $(SAY) > -- cut here -- >=20 > Try "make -U FOO". >=20 > Personally I think this is a reasonable option to implement. > An undefined variable is not the same as a variable which is > defined to be a null string. >=20 I want that everyone understands the effect of the patch: the -U FOO option causes the FOO variable to always be reported by make(1) as undefined, not only in this makefile, but even in sub-make processes, and affects all makefiles wishing to set it -- it just doesn't let them do this, globally. So the actual meaning of this option is "prevent variable FOO =66rom being set". (The implementation is somewhat different; it causes make(1) to lie that variable being is, but the net effect is the same.) Given the above, do we really want this option in our make? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/K/FQUkv4P6juNwoRAo38AJ4wsIqLvP9XYPa5EM93/fZYeio+zwCgiITa oxuryPizIgJFkhdQIIUgbmU= =K3iD -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--