From owner-svn-doc-head@freebsd.org Tue Dec 12 16:44:09 2017 Return-Path: Delivered-To: svn-doc-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63F53E9E8F2; Tue, 12 Dec 2017 16:44:09 +0000 (UTC) (envelope-from wschnr@googlemail.com) Received: from mail-yb0-x22e.google.com (mail-yb0-x22e.google.com [IPv6:2607:f8b0:4002:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 29B94651F4; Tue, 12 Dec 2017 16:44:09 +0000 (UTC) (envelope-from wschnr@googlemail.com) Received: by mail-yb0-x22e.google.com with SMTP id z62so8925423yba.11; Tue, 12 Dec 2017 08:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=54UsfHqtJ5Hm6PvRbfKBPJAeYU+SLHZBbTmRA6JYSzc=; b=pC9vVTzwtFxwNVlMuaavkaGXB6UxWkJq0qMSuqR3IzQ3ADVq0S3u3WnBR2HvES9+qY +xsk0NTh6bqbCIfa9PyfRa4mBr+7tBoW+/KazXJSnJ9nbLJ+BBXa78lu6aTLPSeOxiG0 xUcNVTn12lWYciBeIvvnRuregj062T4LGTqfPmAeQSAPDPG5+H6FiS8PusRcBW0y3KVC 0ViPBnAgYsWF/XLXSUMnawNFos9laMxD6kZQIvY4B7fUbeyrbuKGUPYeL5OTbGIecCBl u3bNDgc6eD1qCbo7uPZWbgWMH15RAI9xb1wfIJmSLJ8c8SCJr5HfF5h65wG3khS6aoFW 4XmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=54UsfHqtJ5Hm6PvRbfKBPJAeYU+SLHZBbTmRA6JYSzc=; b=UbWsGEm5XSGcyJKYEuAg0M+LeqevqgOUZkATe7t3F1Mxm87/Qmhyd1Oivy58ufdWmX 9IEVfCpGm2fQT9SgfNCvAyRpdDGD93Rnl04ehqZVhyX0Dpqo0v93VUsDGlm5Gdyo9ZoF w/ahWIkSkMy/3YLevgMoNG7+p/AW6p0CBwBpZ+2QN9bvYps6nIWxHpX4MVoWmTfO45FR Jt/nq+LsmubaxPk6Zp7aSdB2DfM6dnYgladB7Gr8yARgnUafPTVNUtlKe8w/76+cf69m 45w0aEoLaV5BAVX9ZEgdLBzLaGoXvSZv2IqpR3htushq2x2KwOLJHHrmAtkLGUg+k8ES vD7Q== X-Gm-Message-State: AKGB3mKtQ03EBhJdTL4RoljH+fcjrN6oDAhd85mQYNxbt9+Qv7vmLwyN ZHWVj410iC7UAKvYikaLAsHmPXtu2/Y5qbAc8X7TXw== X-Google-Smtp-Source: ACJfBosNMzLG43vUUpu/IjBKqfb5uZBEzIBoQuupSZWpOHDWjAEBA+PLy5MjsqOExdN1Tq5L3sMkHZwhowtUXvVRKdA= X-Received: by 10.37.160.199 with SMTP id i7mr3309514ybm.386.1513097048061; Tue, 12 Dec 2017 08:44:08 -0800 (PST) MIME-Version: 1.0 Sender: wschnr@googlemail.com Received: by 10.37.9.80 with HTTP; Tue, 12 Dec 2017 08:43:52 -0800 (PST) In-Reply-To: <20171212141917.GJ17600@FreeBSD.org> References: <201712061850.vB6IoXbm056341@repo.freebsd.org> <20171212141917.GJ17600@FreeBSD.org> From: Wolfram Schneider Date: Tue, 12 Dec 2017 17:43:52 +0100 X-Google-Sender-Auth: 7Y7AfSZDIBq0ATqAi56VAwE9HN0 Message-ID: Subject: Re: svn commit: r51260 - in head: en_US.ISO8859-1/htdocs/doc share/pgpkeys To: Glen Barber , Wolfram Schneider Cc: doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-doc-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the doc tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 16:44:09 -0000 On 12 December 2017 at 15:19, Glen Barber wrote: > On Tue, Dec 12, 2017 at 01:17:11PM +0100, Wolfram Schneider wrote: >> On 6 December 2017 at 19:50, Glen Barber wrote: >> > Author: gjb >> > Date: Wed Dec 6 18:50:32 2017 >> > New Revision: 51260 >> > URL: https://svnweb.freebsd.org/changeset/doc/51260 >> > >> > Log: >> > Fix generating pgpkeyring.txt when it does not exist, which seems >> > to have been broken following r51076 or r51077. >> >> What do you mean with 'Fix generating pgpkeyring.txt when it does not exist'? >> >> The file pgpkeyring.txt will be created while building the English >> docs for the web site: >> >> $ make -C en_US.ISO8859-1/htdocs all >> >> and then you will have the file >> doc/share/pgpkeys/pgpkeyring.txt >> >> Your commit breaks `make -j' (parallel build) >> >> $ make -j32 p-all >> >> ===> articles/bsdl-gpl (all) >> keyring.xml:16385: parser error : CData section not finished >> >> -----BEGIN PGP PUBLIC KEY BLOCK----- >> mQINBFJCuag >> --- all_subdir_books/handbook --- >> ===> books/handbook (all) >> --- all_subdir_articles/contributing --- >> ===> articles/contributing (all) >> 1Ss13Y8Vf5UxzEvY8O8c4lT4XOVQLuDEZn7nUcmMBr+b0haGwTW1lrQv1DvPEo0 >> ^ >> >> keyring.xml:16385: parser error : Premature end of data in tag >> programlisting line 16087 >> 1Ss13Y8Vf5UxzEvY8O8c4lT4XOVQLuDEZn7nUcmMBr+b0haGwTW1lrQv1DvPEo0 >> ^ >> >> keyring.xml:16385: parser error : Premature end of data in tag keyring line 2 >> 1Ss13Y8Vf5UxzEvY8O8c4lT4XOVQLuDEZn7nUcmMBr+b0haGwTW1lrQv1DvPEo0 >> ^ >> >> unable to parse keyring.xml >> *** [pgpkeyring] Error code 6 >> >> make[2]: stopped in /tmp/doc-build.PU3aNQj/doc/share/pgpkeys >> A failure has been detected in another branch of the parallel make >> > > Prior to this change pgpkeyring.txt was never created, and as such > failed to install. I checked the timestamp of the file on the build > machine in the cluster, and confirmed it was not being generated there > as well, eliminating a local issue. > > install -C -o gjb -g gjb -m 444 imagelib/callouts/21.png /home/gjb/public_html/FreeBSD/data/doc/en_US.ISO8859-1/books/porters-handbook/imagelib/callouts > /home/gjb/public_html/FreeBSD/data/doc/en_US.ISO8859-1/books/porters-handbook/handbook.html -> /home/gjb/public_html/FreeBSD/data/doc/en_US.ISO8859-1/books/porters-handbook/index.html > /home/gjb/public_html/FreeBSD/data/doc/faq -> /home/gjb/public_html/FreeBSD/data/doc/en_US.ISO8859-1/books/faq > /home/gjb/public_html/FreeBSD/data/doc/handbook -> /home/gjb/public_html/FreeBSD/data/doc/en_US.ISO8859-1/books/handbook > /home/gjb/public_html/FreeBSD/data/doc/en -> /home/gjb/public_html/FreeBSD/data/doc/en_US.ISO8859-1 > cp -f /freebsd/doctemp/share/pgpkeys/pgpkeyring.txt /home/gjb/public_html/FreeBSD/data/doc/pgpkeyring.txt > cp: /freebsd/doctemp/share/pgpkeys/pgpkeyring.txt: No such file or directory > *** Error code 1 > > Stop. > make[1]: stopped in /freebsd/doctemp/en_US.ISO8859-1/htdocs/doc > *** Error code 1 Did you run 'make all' before 'make install'? You must run "all" before "install". Install does not build files, it will install them only. "install" assume that you run the "all" target before, it will not run "all" automatically. I did a quick test and I see that pgpkeyring.txt was generated prior to your commit: git clone -q https://github.com/freebsd/freebsd-doc doc cd doc; git checkout 182028aed582df013ac090340325eff65a6f8e4e ENGLISH_ONLY=YES time make -C en_US.ISO8859-1/htdocs all >& all.log real 3m30.506s user 3m4.873s sys 0m27.697s find . -name 'pgp*.txt' ./share/pgpkeys/pgpkeyring.txt and time make -C en_US.ISO8859-1/htdocs install >& install.log will install pgpkeyring.txt in ~/public_html/data/doc/pgpkeyring.txt -Wolfram > I have an idea on how to resolve the parallel build issue you reported. > It will take some time to verify the behavior is correct. > > Glen > -- Wolfram Schneider https://wolfram.schneider.org