From owner-cvs-all@FreeBSD.ORG Thu Feb 12 17:07:02 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F4FA16A4CE; Thu, 12 Feb 2004 17:07:02 -0800 (PST) Received: from kientzle.com (h-66-166-149-50.SNVACAID.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73F2E43D1D; Thu, 12 Feb 2004 17:07:02 -0800 (PST) (envelope-from kientzle@acm.org) Received: from acm.org ([66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i1D16xkX026499; Thu, 12 Feb 2004 17:06:59 -0800 (PST) (envelope-from kientzle@acm.org) Message-ID: <402C2330.90304@acm.org> Date: Thu, 12 Feb 2004 17:06:56 -0800 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200402120411.i1C4Bf8U036349@repoman.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit cc: cvs-src@FreeBSD.org cc: Tim Kientzle cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/lib/libarchive Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: kientzle@acm.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2004 01:07:02 -0000 Dag-Erling Smørgrav wrote: > Tim Kientzle writes: > >> Log: >> libarchive itself is now completely clean at WARNS=10 on all architectures. >> >> Unfortunately, the stock zlib.h is not: >> line 885: 'err' parameter shadows global 'err' definition from > > > This is trivial to fix, if we're willing to take zlib.h off the vendor > branch or manage to convince Gailly to take our patch. From the FAQ list at gzip.org/zlib: > > 33. I get this or that compiler or source-code scanner warning when I crank it > up to maximally-pendantic. Can't you guys write proper code? > > Many years ago, we gave up attempting to avoid warnings on every compiler > in the universe. It just got to be a waste of time, and some compilers > were downright silly. So now, we simply make sure that the code always > works. We can certainly send them some patches, but I'm not going to expect too much. Tim