Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Jan 2021 23:03:32 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: bd01a69f4836 - main - nfs_write(): do not call ncl_pager_setsize() after clearing TDP2_SBPAGES
Message-ID:  <202101242303.10ON3WFB076959@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=bd01a69f4836994b50b492883fb5367db41fb506

commit bd01a69f4836994b50b492883fb5367db41fb506
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-01-23 21:40:07 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-01-24 23:02:03 +0000

    nfs_write(): do not call ncl_pager_setsize() after clearing TDP2_SBPAGES
    
    This might unnecessary truncate file undoing extension done by the write.
    
    Reported by:    Yasuhiro Kimura <yasu@utahime.org>
    Reviewed by:    rmacklem
    Tested by:      rmacklem, Yasuhiro Kimura <yasu@utahime.org>
    MFC after:      6 days
    Sponsored by:   The FreeBSD Foundation
---
 sys/fs/nfsclient/nfs_clbio.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sys/fs/nfsclient/nfs_clbio.c b/sys/fs/nfsclient/nfs_clbio.c
index 7d0ff0abff3d..832b44b99c8d 100644
--- a/sys/fs/nfsclient/nfs_clbio.c
+++ b/sys/fs/nfsclient/nfs_clbio.c
@@ -1286,11 +1286,6 @@ again:
 
 out:
 	curthread_pflags2_restore(save2);
-	if ((curthread->td_pflags2 & TDP2_SBPAGES) == 0) {
-		NFSLOCKNODE(np);
-		ncl_pager_setsize(vp, NULL);
-	}
-
 	return (error);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101242303.10ON3WFB076959>