From owner-freebsd-bugs Fri Aug 30 7:10: 7 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7923E37B401 for ; Fri, 30 Aug 2002 07:10:04 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3339F43E42 for ; Fri, 30 Aug 2002 07:10:04 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7UEA4JU060197 for ; Fri, 30 Aug 2002 07:10:04 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7UEA3NR060196; Fri, 30 Aug 2002 07:10:03 -0700 (PDT) Date: Fri, 30 Aug 2002 07:10:03 -0700 (PDT) Message-Id: <200208301410.g7UEA3NR060196@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Elliott Hughes Subject: Re: misc/41947: hexdump(1) unprintable ASCII enhancement [PATCH] Reply-To: Elliott Hughes Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR misc/41947; it has been noted by GNATS. From: Elliott Hughes To: "'freebsd-gnats-submit@FreeBSD.org'" Cc: Subject: Re: misc/41947: hexdump(1) unprintable ASCII enhancement [PATCH] Date: Fri, 30 Aug 2002 15:01:18 +0100 Thinking about it, display.c:197 should read: if (color_option == 1 && iscntrl(*bp) && *bp != 0x7f) { because we shouldn't print the character (0x7f + '@') in all fonts, so it's best avoided. --elliott ********************************************************************* This e-mail and any attachment is confidential. It may only be read, copied and used by the intended recipient(s). If you are not the intended recipient(s), you may not copy, use, distribute, forward, store or disclose this e-mail or any attachment. If you are not the intended recipient(s) or have otherwise received this e-mail in error, you should destroy it and any attachment and notify the sender by reply e-mail or send a message to sysadmin@bluearc.com ********************************************************************* To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message