From owner-freebsd-mobile Thu Sep 12 13:33: 8 2002 Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52DFF37B400; Thu, 12 Sep 2002 13:33:05 -0700 (PDT) Received: from birch.ripe.net (birch.ripe.net [193.0.1.96]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58B6F43E3B; Thu, 12 Sep 2002 13:33:04 -0700 (PDT) (envelope-from marks@ripe.net) Received: from laptop.6bone.nl (cow.ripe.net [193.0.1.239]) by birch.ripe.net (8.12.5/8.11.6) with SMTP id g8CKX2Ku027517; Thu, 12 Sep 2002 22:33:02 +0200 Received: (nullmailer pid 1572 invoked by uid 1000); Thu, 12 Sep 2002 20:33:02 -0000 Date: Thu, 12 Sep 2002 22:33:02 +0200 From: Mark Santcroos To: John Baldwin Cc: mobile@FreeBSD.ORG Subject: Re: pccard re-attach after ACPI S1 resume Message-ID: <20020912203302.GA1520@laptop.6bone.nl> References: <20020912125118.GA1343@laptop.6bone.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-Handles: MS6-6BONE, MS18417-RIPE X-RIPE-Spam-Status: NONE ; -1028 X-RIPE-Spam-Level: Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi John, On Thu, Sep 12, 2002 at 01:25:05PM -0400, John Baldwin wrote: > > + sc->suspended = 0; /* XXX initialize, maybe not here */ > > + > > /* > > * this is here so that when socket_enable calls gettype, trt happens > > */ > > This part you don't need because softc's are zero'd when they are allocated. Ok. But still I need it for the reason below. > What if you just had pccard_resume() always call pccard_attach_card(self), > does that work? Then we do an attach on a slot where we know there isn't anything anyway. That basicly doesn't make sense, and it also spits out all kind of ulgy messages that we don't want/need. > If not, you do have one bug, you should clear sc_suspended after > the pccard_attach_card() in pccard_resume(). No, that's why I set it to zero again in pccard_attach_card(). (Which is called for every slot that has sc->suspended==1) Btw, is this problem specific to me or is just nobody using/reporting this? It would seem like a generic problem. Mark -- Mark Santcroos RIPE Network Coordination Centre http://www.ripe.net/home/mark/ New Projects Group/TTM To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message