From owner-cvs-src@FreeBSD.ORG Tue Aug 1 09:24:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC1EB16A4DF; Tue, 1 Aug 2006 09:24:49 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6B3643D5E; Tue, 1 Aug 2006 09:24:47 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k719Oawg069028; Tue, 1 Aug 2006 13:24:36 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k719OZbV069023; Tue, 1 Aug 2006 13:24:35 +0400 (MSD) (envelope-from yar) Date: Tue, 1 Aug 2006 13:24:34 +0400 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20060801092434.GA68364@comp.chem.msu.su> References: <200607311320.k6VDKihd025119@repoman.freebsd.org> <44CE3042.8060509@errno.com> <20060731170830.GC50797@comp.chem.msu.su> <20060731.191913.139568459.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060731.191913.139568459.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: sam@errno.com, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 09:24:49 -0000 On Mon, Jul 31, 2006 at 07:19:13PM -0600, M. Warner Losh wrote: > In message: <20060731170830.GC50797@comp.chem.msu.su> > Yar Tikhiy writes: > : On Mon, Jul 31, 2006 at 09:30:58AM -0700, Sam Leffler wrote: > : > Yar Tikhiy wrote: > : > > yar 2006-07-31 13:20:44 UTC > : > > > : > > FreeBSD src repository > : > > > : > > Modified files: > : > > libexec/telnetd Makefile > : > > Log: > : > > telnetd(8) doesn't really go to the crunched floppies, > : > > so its Makefile needn't test for RELEASE_CRUNCH. > : > > : > What about folks building crunchgen'd images w/ telnetd; is there an > : > equivalent way to do the same thing w/ the new build knobs? > : > : I'd suggest using WITHOUT_CRYPT=yes, it will have the same effect > : for telnetd. Anyway, the RELEASE_CRUNCH knob's coverage is rather > : limited, it's respected by only those parts of src/ that are included > : in the standard boot floppies--telnetd was just an exception. The > : other exception is inetd, which puts its IPSEC stuff under > : RELEASE_CRUNCH. The better way would be to introduce the > : MK_IPSEC_SUPPORT knob. RELEASE_CRUNCH could be mostly handled in > : a single place then. Few tools build in a really special way if > : RELEASE_CRUNCH is defined; most tools just have crypto, IPX etc > : stuff omitted from them. > > We should test "MK_CRYPT" or "MK_IPSEC_SUPPORT" in the makefiles, set > via WITH/WITHOUT_CRYPT/IPSEC_SUPPORT in configuration files. And those Makefiles that decide whether to do something special depending on the status of RELEASE_CRUNCH can use a more general and convenient knob name, e.g., MK_MINIMAL (would be WITH_MINIMAL in src.conf). -- Yar