From owner-freebsd-current@FreeBSD.ORG Thu Apr 28 15:30:37 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD33816A4CE; Thu, 28 Apr 2005 15:30:37 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CDB443D5C; Thu, 28 Apr 2005 15:30:37 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j3SFYpts023727; Thu, 28 Apr 2005 09:34:51 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <427100CC.8080604@samsco.org> Date: Thu, 28 Apr 2005 09:27:08 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ruslan Ermilov References: <20050428025836.E1ED67306E@freebsd-current.sentex.ca> <20050428145519.GB92579@ip.net.ua> <4270FB26.50805@samsco.org> <20050428152622.GC92579@ip.net.ua> In-Reply-To: <20050428152622.GC92579@ip.net.ua> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org cc: Darren Reed cc: current@freebsd.org Subject: Re: LINT broken due to ipfilter X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2005 15:30:37 -0000 Ruslan Ermilov wrote: > Hi Scott, > > On Thu, Apr 28, 2005 at 09:03:02AM -0600, Scott Long wrote: > >>Ruslan Ermilov wrote: >> >>>The changes from sys/modules/ipfilter/Makefile,v 1.17 should be propagated >>>to sys/conf/{files,options,NOTES}. >>> >>> >>>Cheers, >> >>Please feel free to do this. >> > > Well, the attached patch should do it, though I have near zero experience > with ipfilter, so I won't commit it myself. Darren probably will. :-) > > Even after committing this, there's stil a number of compile-time warnings > on 64-bit platforms that should be fixed before this can be compiled. > Before this, it probably makes sense to comment out IPFILTER in LINT, > and let Darren finish polishing his import. > It's been three days, I think that we've all been patient enough. I meant to fix it yesterday, but forgot to check LINT. Please either commit what you have or comment IPFILTER out of LINT. Either way, it's been more than long enough and you should not be afraid of stepping on any toes or being yelled at. Leaving the tree unbuildable for 3 days is unacceptable. I doubt that any other active OSS project would tolerate it, and I'm sure that Sun wouldn't tolerate it either. Scott