From owner-p4-projects  Tue Sep  3 20: 8:19 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ED73A37B401; Tue,  3 Sep 2002 20:08:09 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7753637B400
	for <perforce@freebsd.org>; Tue,  3 Sep 2002 20:08:09 -0700 (PDT)
Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EB8DB43E42
	for <perforce@freebsd.org>; Tue,  3 Sep 2002 20:08:08 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 5821 invoked from network); 4 Sep 2002 03:08:38 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <perforce@freebsd.org>; 4 Sep 2002 03:08:38 -0000
Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4])
	by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g84386Bv006155;
	Tue, 3 Sep 2002 23:08:07 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020903230806.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200209040252.g842qX1J046634@freefall.freebsd.org>
Date: Tue, 03 Sep 2002 23:08:06 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@FreeBSD.org>
Subject: RE: PERFORCE change 17020 for review
Cc: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 04-Sep-2002 Peter Wemm wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17020
> 
> Change 17020 by peter@peter_mckinley on 2002/09/03 19:51:57
> 
>       Work around GEOM/devfs/specfs/whatever bug.  Do not use
>       O_EXCL as it leaks a permanent exclusive reference.

My guess is it might be a LOOKUP_SHARED bug in vn_open_cred(),
but I could be wrong.
 
> Affected files ...
> 
> .. //depot/projects/ia64/sbin/gpt/gpt.c#10 edit
> 
> Differences ...
> 
> ==== //depot/projects/ia64/sbin/gpt/gpt.c#10 (text+ko) ====
> 
> @@ -285,7 +285,7 @@
>       return (-1);
>  
>   found:
> -     fd = open(device_name, (readonly) ? O_RDONLY : O_RDWR|O_EXCL);
> +     fd = open(device_name, (readonly) ? O_RDONLY : O_RDWR);
>       if (fd == -1)
>               return (-1);
>  

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message