Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2002 23:08:06 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Peter Wemm <peter@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   RE: PERFORCE change 17020 for review
Message-ID:  <XFMail.20020903230806.jhb@FreeBSD.org>
In-Reply-To: <200209040252.g842qX1J046634@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 04-Sep-2002 Peter Wemm wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17020
> 
> Change 17020 by peter@peter_mckinley on 2002/09/03 19:51:57
> 
>       Work around GEOM/devfs/specfs/whatever bug.  Do not use
>       O_EXCL as it leaks a permanent exclusive reference.

My guess is it might be a LOOKUP_SHARED bug in vn_open_cred(),
but I could be wrong.
 
> Affected files ...
> 
> .. //depot/projects/ia64/sbin/gpt/gpt.c#10 edit
> 
> Differences ...
> 
> ==== //depot/projects/ia64/sbin/gpt/gpt.c#10 (text+ko) ====
> 
> @@ -285,7 +285,7 @@
>       return (-1);
>  
>   found:
> -     fd = open(device_name, (readonly) ? O_RDONLY : O_RDWR|O_EXCL);
> +     fd = open(device_name, (readonly) ? O_RDONLY : O_RDWR);
>       if (fd == -1)
>               return (-1);
>  

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020903230806.jhb>