From nobody Thu Apr 16 15:04:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxLrr2JB7z6Znx6 for ; Thu, 16 Apr 2026 15:04:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxLrq727Gz4J6R for ; Thu, 16 Apr 2026 15:04:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776351868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=woxFPc+E5A63CMx8Vv+dxUKxZ5EbsRBKaRSeJC4OiJg=; b=GqhTgaKwLJ84p50RZa5Hkp0BzK62pCqQg19+a9oNI4CUj4/mx30L1UGKaeb35fv2GpaxmL lQJjr+tYnCnYfnE3QPjj7+B+SZLNGTrSVO4MgbS9kOEYlV1i6sHDsX4y750flksaAAxkZq tdy5kilBj1CRaCGKMN57j8TZjAeN/x1Q1E8X3t/mMbhNwlDCKXsWf7ix5I+mjVnzhZKO23 3o00/zDM7HdRBz9fLapcaJAlDSesR2Wo74bqwOkx6Czw9xtfbOfGaShJ0qftFw+WCBbQg2 XqCy00+yHyw/YIZIiig8Y1jmqzLq9l9/LhqjMozjPRTc1C+rymS10b0QWcWMhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776351868; a=rsa-sha256; cv=none; b=OK9p3h83sc+z9EI1I3H0SzZ7mOuNRpEEmJ8iKomad4ZXSM96l9yzx00miQQv2hGvmBz7N3 dLj4sByvutGVoUYv2WcdI3kZfCHTyFS8EF+83vsp8PEcX6F9myV4lyk+/tAuqcV5ULG4aP avOZj5I+L7RiPtTN6ja4SzFTj9yJywUEYGRa3BUaIOIAsfCKtaT22qLnilz3BD4mjQJzWr DvxbfamOm/X0wfdTUxw4R5/b5EuX3FhxCBrK4lxQJofiergfWYV3w0IkrPjZKgcTVyLU/1 IxiHuLByFhHuDO+swEoYFY0aRbBGnSC9n9oRxFNw9KWNy+u+uMBsYPU8xAahlQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776351868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=woxFPc+E5A63CMx8Vv+dxUKxZ5EbsRBKaRSeJC4OiJg=; b=Wkyoso9zuXfQzSm6VkBZmpgRJPVGjGofIVP8N/qXPmQ2HASSAeKTgltJ1Wzcp6MAgq93if yVWm4/dtIxvJcMOzrwWIe0bvBG4BCINsbBj75MAW0ODERokg3X9pJXw1zX8vM7LbcMyePt okmTrGsXwDVH7oORrqzyP0OQDtV1qDvCpK9udSF1qhsdQI+kN7+2XkF7Xx644aK+e3703p xRao4LrYRmvW0Wo9i9LGTHTUM9WN5o/jGYvYzpSrdIpQFwHHGgBD1/2pDl1Uet1tgSBXbf 3RLuv0Azu86RDLwQiAYffjYi5h2Gpt33SMYBxjpVVqGTjUr15cC+P3Wgo8N/hA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fxLrq6Rklz1BlZ for ; Thu, 16 Apr 2026 15:04:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cb50 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 16 Apr 2026 15:04:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 62a81003536e - stable/15 - clapic_handle_intr: KASSERT isrc != NULL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 62a81003536ee6f06707b460e79cae348a7a71d2 Auto-Submitted: auto-generated Date: Thu, 16 Apr 2026 15:04:22 +0000 Message-Id: <69e0fa76.1cb50.16a4b6d0@gitrepo.freebsd.org> The branch stable/15 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=62a81003536ee6f06707b460e79cae348a7a71d2 commit 62a81003536ee6f06707b460e79cae348a7a71d2 Author: Colin Percival AuthorDate: 2026-03-14 01:03:44 +0000 Commit: Colin Percival CommitDate: 2026-04-16 15:03:58 +0000 clapic_handle_intr: KASSERT isrc != NULL If an interrupt arrives at a CPU which isn't expecting that particular vector, intr_lookup_source will return an isrc of NULL and we'll panic when intr_execute_handlers increments *isrc->is_count. Place a KASSERT a few nanoseconds earlier in order to leave some more breadcrumbs for the next person to trip over this behaviour. Tested on: EC2 r8i.96xlarge MFC after: 3 weeks Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D55851 (cherry picked from commit f350063a251c9da0c5ce437eb4c44a2d716b673e) --- sys/x86/x86/local_apic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c index 54026f83dc15..ed9f985dafd5 100644 --- a/sys/x86/x86/local_apic.c +++ b/sys/x86/x86/local_apic.c @@ -1426,6 +1426,9 @@ lapic_handle_intr(int vector, struct trapframe *frame) isrc = intr_lookup_source(apic_idt_to_irq(PCPU_GET(apic_id), vector)); + KASSERT(isrc != NULL, + ("lapic_handle_intr: vector %d unrecognized at lapic %u", + vector, PCPU_GET(apic_id))); intr_execute_handlers(isrc, frame); }