Date: Mon, 29 May 2006 01:48:14 +0700 From: "Khairil Yusof" <kaeru@inigo-tech.com> To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org> Subject: ports/98061: [patch] audio/id3lib Fix UTF-16 writing bug (obtain maintainership) Message-ID: <1148842094.93375@wolverine.inigo-tech.com> Resent-Message-ID: <200605281750.k4SHoB1P034601@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 98061
>Category: ports
>Synopsis: [patch] audio/id3lib Fix UTF-16 writing bug (obtain maintainership)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun May 28 17:50:11 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Khairil Yusof
>Release: FreeBSD 6.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD 6.1-RELEASE #17: Sun May 14 11:28:23 ICT 2006
kaeru@wolverine.inigo-tech.com:/tmp/obj/usr/src/sys/WOLVERINE
>Description:
Fix for bug in id3lib that causes UTF-16 characters to be broken when writing tags
Obtained from Fedora CVS:
http://www.redhat.com/archives/fedora-extras-commits/2005-July/msg01106.html
id3lib bug: #1016290
Request for maintainership of this port.
>How-To-Repeat:
>Fix:
--- id3lib-fix begins here ---
diff -urN id3lib/Makefile id3lib.new/Makefile
--- id3lib/Makefile Mon May 29 01:40:14 2006
+++ id3lib.new/Makefile Mon May 29 01:40:35 2006
@@ -7,12 +7,12 @@
PORTNAME= id3lib
PORTVERSION= 3.8.3
-PORTREVISION= 2
+PORTREVISION= 3
CATEGORIES= audio
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= ${PORTNAME}
-MAINTAINER= ports@FreeBSD.org
+MAINTAINER= kaeru@inigo-tech.com
COMMENT= Library for manipulating ID3v1/v1.1 and ID3v2 tags
USE_ICONV= yes
diff -urN id3lib/files/patch-io_helpers.cpp id3lib.new/files/patch-io_helpers.cpp
--- id3lib/files/patch-io_helpers.cpp Thu Jan 1 07:00:00 1970
+++ id3lib.new/files/patch-io_helpers.cpp Mon May 29 01:40:14 2006
@@ -0,0 +1,14 @@
+--- src/io_helpers.cpp.orig Sun Mar 2 07:23:00 2003
++++ src/io_helpers.cpp Mon May 29 01:23:33 2006
+@@ -363,9 +363,10 @@
+ // Write the BOM: 0xFEFF
+ unicode_t BOM = 0xFEFF;
+ writer.writeChars((const unsigned char*) &BOM, 2);
++ const unsigned char* pdata = (const unsigned char*)data.c_str();
+ for (size_t i = 0; i < size; i += 2)
+ {
+- unicode_t ch = (data[i] << 8) | data[i+1];
++ unicode_t ch = (pdata[i] << 8) | pdata[i+1];
+ writer.writeChars((const unsigned char*) &ch, 2);
+ }
+ }
--- id3lib-fix ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1148842094.93375>