From nobody Mon Apr 20 17:42:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fzt9j2BGQz6ZFdJ for ; Mon, 20 Apr 2026 17:42:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fzt9h68wpz3Zqt for ; Mon, 20 Apr 2026 17:42:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776706968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7lAhEyKW6FgvPAc7ITaButAFL7TJacudlkr0W+0qBrk=; b=pvNrM1ikUI4/OSRMlP1CqLvWe9JC6QXXvLjXTxQziafConaidFkZ5sQjLgFcjTNWLbuByT zJe8fEWJ47GEo2pfXt03gps6RgqDVv00ghOPwXsWiM1Taf+S1HHg83wPc8ih2FLv1HT6tl 6TttErSWi74LAgRhsAHMHf4sT2Z/84Ni+Gtx0eeHrDwDUCGFuPlQgBh5N8HHDaTqDmziG2 kl03gW3PWsx3ZFwce+IhdBwqN9CMhc9P5pdZEG5xoCOOtj2Wuji2z/Jp9LUU4GB4EpXFzF PyVs59yW3kyDbjHOv29J/wbClpvli8w/9bkmGQVU5FLVbU/UWA7jXKsMRGYJ6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776706968; a=rsa-sha256; cv=none; b=e0pWgN6Md3caU3yzrYm35J8WPIwUeFXiiHdSaFloy1OB0ep2QSo/cfZVCLHW8Vw3nuiOjG UbqMFGL/jYiCIIEfzv69990PTtQwlRdJpXMoUGhpKpt1BPQADU1noHqUv/npItRU4wTNp/ JFhfe/nPTUeWevtIxL1+v+hlVJM7AUSMUAEoOrzYtXEYHaSuSVYXufktZNQUXjmPfz4I9c mOoE8rEPsSR5DBU3jPem469k7B2HAuCCMFIXcTK0C6r2q2Znfn7sR0HwdORfBQdlA7cCQa vFu1QBh02Q4+zcyhg6Tr6U7h9j/BG2cZqXIOPtLRZ+iNXzze6EqRd4zNghLzPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776706968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7lAhEyKW6FgvPAc7ITaButAFL7TJacudlkr0W+0qBrk=; b=MCnI/tV1KWQa2wwZ7+8OCAgfmCSDuK42XoviscqLWl2b1/z6SUjayywU37BLBXowDPeCui Doa0HDedpGDv5ZXeyU5BRUYAwvXztS+bGJQjYo0z5xwv1ffImd7iCbqQBfxfxB2Zx24xSn PuKvmj2Oi1wO4ElweZggGDabqrTMuCIIJBofBd3T6JFsYeDo1lLzDfSKAmbD3cpqqFGWdq yZTfH/HAi4WdBm3St161PVZWkwtUqA0lPwxvMXi4Z4DARVXroX4kJBmNdJDfjmZ5Yr4hiq otIRs6mc1X4IbM/vr1j8Jt9T4KVN5mrGzL4RYWZ+a4oC+y6b0Z1XwJqP505dRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fzt9h4yqDz16ms for ; Mon, 20 Apr 2026 17:42:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 419bb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 20 Apr 2026 17:42:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 950fd59955e1 - main - membarrier(2): use atomic for lockless read of curproc->p_flag2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 950fd59955e10429c1325c327f0141a7e97fcfe5 Auto-Submitted: auto-generated Date: Mon, 20 Apr 2026 17:42:48 +0000 Message-Id: <69e66598.419bb.30e88f8e@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=950fd59955e10429c1325c327f0141a7e97fcfe5 commit 950fd59955e10429c1325c327f0141a7e97fcfe5 Author: Konstantin Belousov AuthorDate: 2026-04-18 18:42:56 +0000 Commit: Konstantin Belousov CommitDate: 2026-04-20 17:42:28 +0000 membarrier(2): use atomic for lockless read of curproc->p_flag2 Reviewed by: markj, Ricardo Branco Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D56507 --- sys/kern/kern_membarrier.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sys/kern/kern_membarrier.c b/sys/kern/kern_membarrier.c index f0660bd7360e..6d210a1b1783 100644 --- a/sys/kern/kern_membarrier.c +++ b/sys/kern/kern_membarrier.c @@ -120,7 +120,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) struct thread *td1; cpuset_t cs; uint64_t *swt; - int c, error; + int c, error, f; bool first; if (flags != 0 || (cmd & ~MEMBARRIER_SUPPORTED_CMDS) != 0) @@ -133,6 +133,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) p = td->td_proc; error = 0; + f = atomic_load_int(&td->td_proc->p_flag2); switch (cmd) { case MEMBARRIER_CMD_GLOBAL: @@ -155,7 +156,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) break; case MEMBARRIER_CMD_GLOBAL_EXPEDITED: - if ((td->td_proc->p_flag2 & P2_MEMBAR_GLOBE) == 0) { + if ((f & P2_MEMBAR_GLOBE) == 0) { error = EPERM; } else { CPU_ZERO(&cs); @@ -171,7 +172,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) break; case MEMBARRIER_CMD_REGISTER_GLOBAL_EXPEDITED: - if ((p->p_flag2 & P2_MEMBAR_GLOBE) == 0) { + if ((f & P2_MEMBAR_GLOBE) == 0) { PROC_LOCK(p); p->p_flag2 |= P2_MEMBAR_GLOBE; PROC_UNLOCK(p); @@ -179,7 +180,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) break; case MEMBARRIER_CMD_PRIVATE_EXPEDITED: - if ((td->td_proc->p_flag2 & P2_MEMBAR_PRIVE) == 0) { + if ((f & P2_MEMBAR_PRIVE) == 0) { error = EPERM; } else { pmap_active_cpus(vmspace_pmap(p->p_vmspace), &cs); @@ -188,7 +189,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) break; case MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED: - if ((p->p_flag2 & P2_MEMBAR_PRIVE) == 0) { + if ((f & P2_MEMBAR_PRIVE) == 0) { PROC_LOCK(p); p->p_flag2 |= P2_MEMBAR_PRIVE; PROC_UNLOCK(p); @@ -196,7 +197,7 @@ kern_membarrier(struct thread *td, int cmd, unsigned flags, int cpu_id) break; case MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE: - if ((td->td_proc->p_flag2 & P2_MEMBAR_PRIVE_SYNCORE) == 0) { + if ((f & P2_MEMBAR_PRIVE_SYNCORE) == 0) { error = EPERM; } else { /*