From owner-freebsd-x11@freebsd.org Wed Aug 14 18:04:26 2019 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 693D7B4E5C for ; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467yCG1yZTz3DJH for ; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 425C3B4E59; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) Delivered-To: x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42142B4E58 for ; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467yCG0XRmz3DJB for ; Wed, 14 Aug 2019 18:04:25 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565805864; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=XKvk5DPOHvg9sQkYiTc/aLVXndw/9ziWjVChxSXwut45e7Q4QZujTar4DWJlJ1hsfiWISdvJA+vRp mYTpIZ0sLYVSnB4+G8am6Od1nS3lqTh2msK3TjQth4dm2WDhTGFueMMVhth68sgtsFdlF4VBNk4BP2 Nx/mAWcyjjYhFFtdk+XRJOwvkdljfXN+ZDlhJnI/PYLQcmnAM+HjrIWjI0AWWI+JYSK+Lg9uD8WhEo eVYPdyfFr1sQ8garw+gt8jmSHYmIaYlctO/tYh1Kd7EA2CJvpvksTxbewqu9he7sboFTGZxgolS5gD Mq2o1m5uwm9z6t7aD6LJPqptfWaarPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=/JS/Q+nyRGXqcESnaEfkyCBgdHMRhAMOuxE7bsz1kQA=; b=lZdbW/bf9MZwTfnJi+flm44/69R4jDsIy4h34yFE3V0o54VHFa8lJW0XkZwCrRkEBUkIrXP0Ef4AQ tMPbrTZnlujYIIhsW/4Fca47s8oFNXTikkBqFcdluD7eLVGFmaQ1JkaJ4r8vTp6HKts6PzINtFEEoD 1JgXtFqv0bFjw5Y4XZYMtcgMtkxDDnKsMQQWy6xkOv6tOjWmo7Wev+mA9Q0pP31QEY1x3QvTMmsw6k Rm3Vr6lxuYYXcxfJRo9VPaeqJnO+Gsy65YsNwcw/HaL7GqgPtcEOPZTf1AFs6gjLuPkoLUHeKLomRp YBxDqa3kRdX3lGRnCNxj3C2CIdiegCw== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=/JS/Q+nyRGXqcESnaEfkyCBgdHMRhAMOuxE7bsz1kQA=; b=wspd3VGBWlXMBPdIplq1JxM0SdLCAESP6aX8DVMSp7vGD18j+vHbTfN1p4lubD9RTqG2jZspBHYgZ /PR+PsyZlWBk+uaRe0vJwWT1SVChj9GmlsIMMimrwhYlNxJZM3NC9hrXBpZYQBf/ej5xDPyRmn9IfB mAQL7t7Zv61jU9o7zqaLk71cn6tNifqVBRDuwNKZaIPpRJhlWmVICF1rpNA5RfR4tN0yvgf8RELvG6 hlgX6GJpfq9Oyu2mIdmmp1avO9vwhjDYIdAydjexqGacGS5ZlwL9C8tSZLc4irPTWn2WDjXyqP0+fV pGef+pBTTr2f6aMOZC9mArzmOzIEasw== X-MHO-RoutePath: aGlwcGll X-MHO-User: f0df667c-bebd-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id f0df667c-bebd-11e9-b67b-cdd75d6ce7a8; Wed, 14 Aug 2019 18:04:22 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7EI4KFL055387; Wed, 14 Aug 2019 12:04:20 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: Niclas Zeising , Emmanuel Vadot , John Baldwin Cc: x11@FreeBSD.org, current@FreeBSD.org Date: Wed, 14 Aug 2019 12:04:20 -0600 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467yCG0XRmz3DJB X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:04:26 -0000 On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: > On 2019-08-14 19:23, Emmanuel Vadot wrote: > > On Wed, 14 Aug 2019 10:13:48 -0700 > > John Baldwin wrote: > > > > > On 8/14/19 9:22 AM, Ian Lepore wrote: > > > > This all sounds vaguely wrong, backwards, to me. A developer > > > > who is > > > > using a given module on their build system might want that > > > > module to be > > > > rebuilt automatically, but only if the build parameters match > > > > those of > > > > the running build host system. > > > > > > > > If my build host is running freebsd 12 amd64 and I'm doing a > > > > build for > > > > freebsd 13 armv7, I have no interest in automatic rebuilds of > > > > an amd64 > > > > driver module for a different OS arch and version just because > > > > that > > > > module happens to be installed on the system I use to do > > > > crossbuilds. > > > > > > > > My objections are theoretical... this automation just seems > > > > improperly > > > > designed to me. But it won't actually affect me in any way, > > > > because I > > > > don't build video driver modules from ports, and I don't run > > > > freebsd > > > > current on my build host machine. Probably the number of > > > > people doing > > > > crossbuilding is small enough that nobody else is going to > > > > object to > > > > this "the whole world is amd64" automation. > > > > > > You assume DRM is amd64-only when it is definitely not. It also > > > has > > > suitable guards in its Makefile to only build the relevant kernel > > > modules on supported architectures. > > > > I clearly don't want to spend time to build the drm and radeon > > modules > > when I'm hacking on arm64. > > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > > subdirectory ? So when you install drm-kmod-* it will only install > > the > > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or > > whatever > > the correct dir is). > > > > I'm not sure what you're trying to accomplish. I might be > misunderstanding completely, but, at least the drm ports have > safeguards > in their makefiles so they'll only be built for those arches where > there > is support, and only the modules needed, as an example, i915kms.ko > will > only be built on amd64 and i386, if that's what you're worried about. > Regards I can't understand what you guys are not-understanding. New machinery has been added that says "if some module source code exists in this absolute fixed location on the build machine, then whenever you do any kernel build for any OS version or any arch, rebuild that module source code so that the the build machine's video drivers stay in sync with the build machine's kernel." Do you not see that for some of us, only a tiny fraction of the builds done (maybe none of them at all) involve the kernel for the build host machine or the video drivers for the build host machine? And yet, for us, every build we do will now inapppropriately rebuild this video driver module which has nothing to do with the machine the build is targeting. And it's not just about crossbuilds, because it's about versions too. Even when a developer is running 13-current and wants their video driver rebuilt and installed automatically along with the kernel, they're certainly going to want that to happen only when they're building 13-current. If they're doing a test-build for 12-stable they certainly aren't going to want to build and install that video driver. -- Ian