Date: Sat, 27 Sep 2008 13:19:09 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_conf.c src/sys/sys systm.h types.h Message-ID: <200809271320.m8RDKIj7097399@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2008-09-27 13:19:09 UTC FreeBSD src repository Modified files: sys/kern kern_conf.c sys/sys systm.h types.h Log: SVN rev 183406 on 2008-09-27 13:19:09Z by ed Move uminor() and umajor() to the same place as userspace minor() and major(). The uminor() and umajor() functions have the same use in kernel space as the minor() and major() functions in userspace. If we ever get rid of the minor() function in kernel space, we could decide to just expose minor() and major() to kernel space, making uminor() and umajor() redundant. There are two reasons why we want to have uminor() and umajor() in <sys/types.h>: - Having them close together prevents them from diverting. Even though it's unlikely the definitions will change, it's a good habit to have them at the same place. - They don't really belong in kern_conf.c. kern_conf.c has been liberated from dealing with device major and minor number handling. The device_ids(9) manpage now lists the wrong #include's, because it should only list <sys/types.h> now. I'm leaving it as it is now, because I wonder if we should document them anyway. We're probably better off documenting minor(3) and major(3). Revision Changes Path 1.224 +0 -14 src/sys/kern/kern_conf.c 1.269 +0 -2 src/sys/sys/systm.h 1.100 +11 -6 src/sys/sys/types.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809271320.m8RDKIj7097399>