From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Jun 25 11:30:13 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 841D016A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri, 25 Jun 2004 11:30:13 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7D33743D5F
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri, 25 Jun 2004 11:30:13 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i5PBUDsW049090	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Fri, 25 Jun 2004 11:30:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5PBUDpc049089;
	Fri, 25 Jun 2004 11:30:13 GMT
	(envelope-from gnats)
Date: Fri, 25 Jun 2004 11:30:13 GMT
Message-Id: <200406251130.i5PBUDpc049089@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: "Volker Stolz" <vs@freebsd.org>
Subject: Re: ports/68215: NEW PORT: multimedia/freevo, an open-source home
	theatre PC platform
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Volker Stolz <vs@freebsd.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jun 2004 11:30:13 -0000

The following reply was made to PR ports/68215; it has been noted by GNATS.

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, purple@lewiz.net
Cc:  
Subject: Re: ports/68215: NEW PORT: multimedia/freevo, an open-source home theatre PC platform
Date: Fri, 25 Jun 2004 13:27:21 +0200

 ...
 # Should these have exists() ?
 # Without them freevo setup still detects applications but ports doesn't
 # create the full dependency list.
 .if defined(WITH_XINE)
 RUN_DEPENDS+=xine:${PORTSDIR}/multimedia/xine
 .endif
 
 This is not good. You should always record the exact dependencies.
 Please *also* use exists() ("... exists(foo) || defined(WITH_FOO)...".  
 Provide some sanity-checks,
 in case WITH_foo and autodetection conflict. Or maybe there's something  
 like configure's
 --disable-foo, which will prevent feature-detection?
 
 Volker