Date: Tue, 12 Mar 2019 17:42:52 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Koichiro Iwao <meta@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495325 - in head: . converters converters/pdf2djvu converters/pdf2djvu/files Message-ID: <20190312164252.gy24ciagttvxnnmw@ogg.in.absolight.net> In-Reply-To: <20190312155505.qg37ghznbwqoo6vk@icepick.vmeta.jp> References: <201903110232.x2B2W4aP026085@repo.freebsd.org> <20190312142649.mcouvbxfjawaozou@ogg.in.absolight.net> <20190312143934.fansco76gw5j5t2f@icepick.vmeta.jp> <20190312144438.qiuzovf7zclpn5pa@ogg.in.absolight.net> <20190312155505.qg37ghznbwqoo6vk@icepick.vmeta.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--ezdqe7kxo4ur6doh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Mar 13, 2019 at 12:55:05AM +0900, Koichiro Iwao wrote:
> On Tue, Mar 12, 2019 at 03:44:38PM +0100, Mathieu Arnold wrote:
> > On Tue, Mar 12, 2019 at 11:39:34PM +0900, Koichiro Iwao wrote:
> > > On Tue, Mar 12, 2019 at 03:26:49PM +0100, Mathieu Arnold wrote:
> > > > On Mon, Mar 11, 2019 at 02:32:04AM +0000, Koichiro Iwao wrote:
> > > > > +USE_GITHUB=3D yes
> > > > > +GH_TUPLE=3D jwilk:${PORTNAME}:${PORTVERSION}
> > > >=20
> > > > GH_ACCOUNT=3D jwilk
> > >=20
> > > Yes, but what?
> > >=20
> > > $ make -C /usr/ports/converters/pdf2djvu -VGH_ACCOUNT
> > > jwilk
> >=20
> > I was merely pointing out that what you wrote was bad and the correct
> > way to express what you had meant.
>=20
> You like beating around the bush.
Well, there is a simple, and correct, way to do what you want to do, it
is to set:
GH_ACCOUNT=3D jwilk
And there is the complicated way you used. The way you used will make
other people looking at the Makefile wonder why you did it that way, if
there was a reason to set GH_TUPLE to a complex value instead of siply
GH_ACCOUNT, like some strange bug that you wanted to get around but
forgot to mention in the commit message.
If you do not with to get post-commit review of your changes so that we
all get a simpler and easier to deal with ports tree, please say so.
--=20
Mathieu Arnold
--ezdqe7kxo4ur6doh
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlyH4YxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkjxig/6AntuIZAncT4gZ5xy4WpPgMh3/pNR4y96TdRWc3riLiZD3khO40T3Tmer
dE4U9RuRfE2iVMSYDC8svKjghFCfQBTFnBegjPw0aweXjyGD3y0sF9/2Fk+lUTDx
PwnINqLJyGks3NF1lUU66AiebpvgL6cwe5yMe6UQ2Gq9BBh9ogZEcw/l79IlcbWE
T210yNJOdmKMVMvdwPt5u9THOheEXyAJs72nw9vpTosBoUmdWvcf+y1LHhD7HzNq
yTniMfU2bXQ9Ybwo/6jeKIQC4M/1DiAA2ynL6UiyiG1mP1bBTZAU08k2z+4GEsN3
JcjiYtnN/W1dwLow6BcWpXKns83D8Fvow/1llGjCRZMrfXvSHIUQDjh8zKgKd055
4+t/jR4GtHCIEYIB1O3uqZw/JxyaK7B/pyc+u6Cao3Qy5VYI6yA/gmU3mNClP+Ml
a8huMfoVSsw2p/N4k4UAxD2ytAz1ESTlvkOMgUFY9v7jCBdwFSExA8UUag6QeGH6
Eps+oEwgvW5aE1wiW/dwj+KVdSIGr/hxxVuOao41EVNfAiWe5CYn2m6oOjgdJIwB
6yCflGoGOkczzHUHMh9yB+hGlX6XRjwB65eNwOfCDrx8pVSs4m8VLGzEQYQdGrPj
zNk/6qYyK6m/qg70DQNSVwvAZIfABLEIw46AXhpugV2yyy3xjak=
=XQkF
-----END PGP SIGNATURE-----
--ezdqe7kxo4ur6doh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190312164252.gy24ciagttvxnnmw>