From owner-svn-src-all@FreeBSD.ORG Fri Jun 28 06:20:25 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 32EA6B05; Fri, 28 Jun 2013 06:20:25 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pb0-x22b.google.com (mail-pb0-x22b.google.com [IPv6:2607:f8b0:400e:c01::22b]) by mx1.freebsd.org (Postfix) with ESMTP id F3971175A; Fri, 28 Jun 2013 06:20:24 +0000 (UTC) Received: by mail-pb0-f43.google.com with SMTP id md12so1866100pbc.30 for ; Thu, 27 Jun 2013 23:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=9huNDZysN8T6PlPNEdu2/rMrjwWasE5KBLgecSFKMPQ=; b=j1/INUTilNQy9uiMauOQcopI+s069Juka9rbqcpanUSLAOOa6F2338kgRSsT6kidlO omOBscdSlyZthir1AlZDK1eagmSz6+O2x70N8tspHPTCp/iRK0s9x7I88zPWxcXigmHT GQ3XOt7I5W+nB11q1t3nc1H51dw+PoXYhwqNk3m9lOpEWHVxliikZ0ERHAuVMgmJwGMn E8DEG+e5wwJvdRkyFt0E+1mxbP5lcTtCHoko9P0z4pvmQptybZm84ijEiUGDIX9KsCRq fTIEGnb/mIS8L2cUZ6ENDKGggQzWuF5+DmisDCGEYlideshYI3Fdtc1faJFfBUe3dIOO DBmA== X-Received: by 10.66.217.195 with SMTP id pa3mr9888221pac.120.1372400424754; Thu, 27 Jun 2013 23:20:24 -0700 (PDT) Received: from [192.168.20.5] (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPSA id py6sm3132907pbb.33.2013.06.27.23.20.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Jun 2013 23:20:24 -0700 (PDT) Subject: Re: svn commit: r252101 - head/release Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=windows-1252 From: Garrett Cooper In-Reply-To: <20130622225106.GK1888@glenbarber.us> Date: Thu, 27 Jun 2013 12:13:51 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <1D76B2CE-575C-4456-BC3A-7249D030970A@gmail.com> References: <201306222212.r5MMCO8t091190@svn.freebsd.org> <1397DF51-1DCC-47BC-931A-5D26C94A0811@gmail.com> <20130622225106.GK1888@glenbarber.us> To: Glen Barber X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jun 2013 06:20:25 -0000 On Jun 22, 2013, at 3:51 PM, Glen Barber wrote: > On Sat, Jun 22, 2013 at 03:39:41PM -0700, Garrett Cooper wrote: >> On Jun 22, 2013, at 3:12 PM, Glen Barber wrote: >>=20 >>> Author: gjb >>> Date: Sat Jun 22 22:12:24 2013 >>> New Revision: 252101 >>> URL: http://svnweb.freebsd.org/changeset/base/252101 >>>=20 >>> Log: >>> If MAKE_CONF and/or SRC_CONF are set and not character devices, >>> copy to chroot to use with release build. >>>=20 >>> Submitted by: Garrett Cooper (original version) >>> Approved by: kib (mentor) >>> MFC after: 1 week >>>=20 >>> Modified: >>> head/release/release.sh >>=20 >> Technically copying /dev/null to a file creates a 0 byte file. >> That's why I used cp in the patch I submitted over email. >> Thanks! >=20 > Right. But did you read the script? >=20 > Both __MAKE_CONF and SRCCONF are set to the path of the local files. Oh, interesting=85 I see what you did there instead of what I = proposed; I copied __MAKE_CONF to /etc/make.conf and SRCCONF to = /etc/src.conf for symmetry with the base system, but your method works = more than mine did (I forgot that you were passing those vars in the = chroot environment). Should the files be installed to /etc/ in the = system default locations ? Thanks! -Garrett=