From owner-svn-src-all@freebsd.org Wed Dec 7 21:32:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB8B6C6C235 for ; Wed, 7 Dec 2016 21:32:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9402F15CB for ; Wed, 7 Dec 2016 21:32:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x243.google.com with SMTP id h133so31009683ioe.2 for ; Wed, 07 Dec 2016 13:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9XMgmbKOt8xTmqxZInPDk/XdJVWzGiTXPARFpOIZ60Y=; b=hDMH5wcH6aDQkvxLIjHReCyCrPYcBEfubnXY4zSrEghThqf8Pna7f0vSvPlec6hwa3 Alc1phzxBnCWJ3+cylZq+YhDThHShKWtxjshMRZGwxrWa5HZTZcNxJV3t+HJMAFF2GBd 0pRu0cccM3IDwhh6SThC8CUjk9pAU7o/g+dkypgfgUaq8GuEfUhnwFWsguwh+QYgT+U0 61gQ1mjX3IrFZrAOs73+Z7Rt8CtdT5mtlelVDhUFPIn8l3eeu8enH59y5F+qAQv47XZf bK46gldRORiJ39roWdUJiS/T3bxrECEAd5nJoGrqDVdgYV0g87QrXCXNba39HAqXgTXb sdlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9XMgmbKOt8xTmqxZInPDk/XdJVWzGiTXPARFpOIZ60Y=; b=aiYf1l5R7/GUtYiQyBx1lcbxOT2UuynAd+goxY2ck0qNjjWGfIZUXnIXwkxe5/hEmZ bsQ8NizYMYXxfLFcFd4OAYuH2sLPtxaHd2Cy/WYqgzoYxkrwj6E9hh87ZXhqc1IE0w6f UCHFelFi98vL3HWboDUA/TQ0im7Wd+0/DPGmv5BpMEZ7yHnc1c/2GSGQqkMU/FbTUx3Y 25X09RaUq51sarLM5++Y9Sp96f3R+pKBxX/3G/yY/v4ZgPin4OCkmRJ/i7oMyVTZCH8z /5DUKmxhVV6VnLZTUTMc2eiDmG3/UrVfJM2EeP0SbujC4HNYcuaA134pJxgk/+wmkpCu b40g== X-Gm-Message-State: AKaTC02a+FmyOGDEHLi43rX6774bCWgSra0ZRi1rad36sEAmMIK8jMfGFIg5VGwCOCmtPg9xOxo2Ede7O/4wDg== X-Received: by 10.36.122.135 with SMTP id a129mr4060289itc.103.1481146373948; Wed, 07 Dec 2016 13:32:53 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.31.199 with HTTP; Wed, 7 Dec 2016 13:32:53 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <20161207212647.GO27748@FreeBSD.org> References: <201612062252.uB6Mqjhr019191@repo.freebsd.org> <20161207212647.GO27748@FreeBSD.org> From: Warner Losh Date: Wed, 7 Dec 2016 14:32:53 -0700 X-Google-Sender-Auth: etM92BqjYqGFPTqXdsZBK6EqA_A Message-ID: Subject: Re: svn commit: r309658 - head/sys/vm To: Gleb Smirnoff Cc: Mark Johnston , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 21:32:54 -0000 On Wed, Dec 7, 2016 at 2:26 PM, Gleb Smirnoff wrote: > On Tue, Dec 06, 2016 at 10:52:45PM +0000, Mark Johnston wrote: > M> Author: markj > M> Date: Tue Dec 6 22:52:45 2016 > M> New Revision: 309658 > M> URL: https://svnweb.freebsd.org/changeset/base/309658 > M> > M> Log: > M> Provide dummy sysctls for v_cache_count and v_tcached. > M> > M> Some utilities (notably top(1)) exit if any of their input sysctls don't > M> exist, and the removal of the above-mentioned PG_CACHE-related sysctls > M> makes it difficult to run such utilities on different versions of the > M> kernel without recompiling. > M> > M> Requested by: bde > M> > M> Modified: > M> head/sys/vm/vm_meter.c > M> > M> Modified: head/sys/vm/vm_meter.c > M> ============================================================================== > M> --- head/sys/vm/vm_meter.c Tue Dec 6 22:48:28 2016 (r309657) > M> +++ head/sys/vm/vm_meter.c Tue Dec 6 22:52:45 2016 (r309658) > M> @@ -314,3 +314,14 @@ VM_STATS_VM(v_forkpages, "VM pages affec > M> VM_STATS_VM(v_vforkpages, "VM pages affected by vfork()"); > M> VM_STATS_VM(v_rforkpages, "VM pages affected by rfork()"); > M> VM_STATS_VM(v_kthreadpages, "VM pages affected by fork() by kernel"); > M> + > M> +#ifndef BURN_BRIDGES > M> +/* > M> + * Provide compatibility sysctls for the benefit of old utilities which exit > M> + * with an error if they cannot be found. > M> + */ > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_cache_count, CTLFLAG_RD, > M> + (u_int *)NULL, 0, "Dummy for compatibility"); > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_tcached, CTLFLAG_RD, > M> + (u_int *)NULL, 0, "Dummy for compatibility"); > M> +#endif > > IMHO, there should be some garbage collecting timeout for them. I'd suggest to > delete them from head after stable/12 branch is forked. Other places define #if BURN_BRUDGES < 1200000 to make this automatic. Warner