From owner-cvs-all Thu Oct 17 18:24:20 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 899CA37B401; Thu, 17 Oct 2002 18:24:19 -0700 (PDT) Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7152543E77; Thu, 17 Oct 2002 18:24:18 -0700 (PDT) (envelope-from Scott_Long@adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11] (may be forged)) by magic.adaptec.com (8.10.2+Sun/8.10.2) with ESMTP id g9I1OH501969; Thu, 17 Oct 2002 18:24:17 -0700 (PDT) Received: from OTCEXC01.otc.adaptec.com (otcexc01.otc.adaptec.com [10.12.1.27]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id SAA18710; Thu, 17 Oct 2002 18:24:16 -0700 (PDT) Received: by otcexc01.otc.adaptec.com with Internet Mail Service (5.5.2653.19) id <4TQCW0QX>; Thu, 17 Oct 2002 21:24:16 -0400 Message-ID: <6100BCEB85F8E244959C756C04E0EDD161CACC@otcexc01.otc.adaptec.com> From: "Long, Scott" To: "'Jim Pirzyk'" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/cam/scsi scsi_cd.c Date: Thu, 17 Oct 2002 21:24:15 -0400 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > pirzyk 2002/10/17 16:37:09 PDT > > Modified files: > sys/cam/scsi scsi_cd.c > Log: > Changed the scsi mode command to use 10 bytes scsi commands instead > of the 6 byte ones. This helps with using a IDE cdrom behind a USB > interface. > > PR: kern/43885 > > Revision Changes Path > 1.65 +11 -9 src/sys/cam/scsi/scsi_cd.c > Um, who was this reviewed by? CAM in general is a touchy place to tread, but the cd driver in particular has an active maintainer who has requested that changes be reviewed by him first. Changing something that could cause compatibility problems definitely needs review. Scott To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message