From owner-freebsd-fs@freebsd.org  Sun Oct 16 12:16:08 2016
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A5A0C13F70
 for <freebsd-fs@mailman.ysv.freebsd.org>; Sun, 16 Oct 2016 12:16:08 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 099AD1AA9
 for <freebsd-fs@FreeBSD.org>; Sun, 16 Oct 2016 12:16:08 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9GCG7Kn054555
 for <freebsd-fs@FreeBSD.org>; Sun, 16 Oct 2016 12:16:07 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-fs@FreeBSD.org
Subject: [Bug 213507] [msdosfs] [patch]: Prevent occasional directory
 corruption while extending it to another cluster
Date: Sun, 16 Oct 2016 12:16:08 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: vladislav.movchan@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-213507-3630-5ZIlFSXyar@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213507-3630@https.bugs.freebsd.org/bugzilla/>
References: <bug-213507-3630@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Oct 2016 12:16:08 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213507

--- Comment #7 from Vladislav Movchan <vladislav.movchan@gmail.com> ---
(In reply to Konstantin Belousov from comment #5)
I confirmed your hypothesis - sometimes buffer pages have valid bits set and
sometimes they don't.
Original problem occurs only in cases when valid bits are set, so
vfs_bio_clrbuf() don't zero random data in buffer.

Also I went through history and found that originally buffer data was always
zeroed by call to clrbuf() macro and in base r171522 it was changed to
vfs_bio_clrbuf() as an optimization.

I suppose what I see is just a regression of this optimization and it was n=
ot
noticed since then as "directory extension to another cluster" is a rare
operation.

I attached another patch which restores original behaviour just for the
"directory grows" case.
With this patch I'm no longer able to reproduce this problem.

--=20
You are receiving this mail because:
You are the assignee for the bug.=