From owner-svn-src-head@freebsd.org  Sun Dec  3 18:36:02 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C57DE5E95A;
 Sun,  3 Dec 2017 18:36:02 +0000 (UTC)
 (envelope-from srs0=cguf=c7=freebsd.org=kp@codepro.be)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 45EA82883;
 Sun,  3 Dec 2017 18:36:02 +0000 (UTC)
 (envelope-from srs0=cguf=c7=freebsd.org=kp@codepro.be)
Received: from [10.0.2.164]
 (ptr-8ripyygs3omapxtynip.18120a2.ip6.access.telenet.be
 [IPv6:2a02:1811:2419:4e02:9caa:8c46:a76c:1c91])
 (Authenticated sender: kp)
 by venus.codepro.be (Postfix) with ESMTPSA id 2780C42890;
 Sun,  3 Dec 2017 19:36:00 +0100 (CET)
From: "Kristof Provost" <kp@FreeBSD.org>
To: "Alan Somers" <asomers@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r326497 - in head: etc/mtree tests/sys
 tests/sys/netipsec tests/sys/netipsec/tunnel
Date: Sun, 03 Dec 2017 19:35:59 +0100
X-Mailer: MailMate (2.0BETAr6099)
Message-ID: <D0CA8D17-6A07-488E-BEF4-DC20C31809B3@FreeBSD.org>
In-Reply-To: <CAOtMX2g8dU6v+Pam3akQKO8zVVWJjWwbY+0LX-FYjkdsi2sH5A@mail.gmail.com>
References: <201712031352.vB3DqZF3084841@repo.freebsd.org>
 <CAOtMX2g8dU6v+Pam3akQKO8zVVWJjWwbY+0LX-FYjkdsi2sH5A@mail.gmail.com>
MIME-Version: 1.0
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Dec 2017 18:36:02 -0000

On 3 Dec 2017, at 19:20, Alan Somers wrote:
> On Sun, Dec 3, 2017 at 6:52 AM, Kristof Provost <kp@freebsd.org> wrote:
>
>> Author: kp
>> Date: Sun Dec  3 13:52:35 2017
>> New Revision: 326497
>> URL: https://svnweb.freebsd.org/changeset/base/326497
>>
>> Log:
>>   Add IPSec tests in tunnel mode
>>
>>   Some IPSec in tunnel mode allowing to test multiple IPSec
>>   configurations.  These tests are reusing the jail/vnet scripts from pf
>>   tests for generating complex network.
>>
>>   Submitted by: olivier@
>>   Differential Revision:        https://reviews.freebsd.org/D13017
>>
> It's not ok to use kldunload during the test heads.  Everything  in the
> head methods gets executed when you do "kyua list".  Anything output gets
> interpreted by Kyua.  In this case, if kldunload outputs anything at all,
> Kyua will consider it to be a syntax error, and it will skip the entire
> file.  You should limit yourself to using just atf_set in the header.  Move
> the kld commands into the test case bodies.
>
Thanks. Done in r326500.

Regards,
Kristof