From owner-cvs-all Fri Dec 14 16:58:45 2001 Delivered-To: cvs-all@freebsd.org Received: from avocet.prod.itd.earthlink.net (avocet.mail.pas.earthlink.net [207.217.120.50]) by hub.freebsd.org (Postfix) with ESMTP id 1C5CF37B419; Fri, 14 Dec 2001 16:58:39 -0800 (PST) Received: from dialup-209.245.137.160.dial1.sanjose1.level3.net ([209.245.137.160] helo=blossom.cjclark.org) by avocet.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16F39w-0003V2-00; Fri, 14 Dec 2001 16:58:37 -0800 Received: (from cjc@localhost) by blossom.cjclark.org (8.11.6/8.11.3) id fBF0wXr04989; Fri, 14 Dec 2001 16:58:33 -0800 (PST) (envelope-from cjc) Date: Fri, 14 Dec 2001 16:58:32 -0800 From: "Crist J . Clark" To: Ruslan Ermilov Cc: Guido van Rooij , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/periodic/security 550.ipfwlimit 650.ip6fwlimit Message-ID: <20011214165832.B3473@blossom.cjclark.org> References: <200112140858.fBE8wL596075@freefall.freebsd.org> <20011214115711.A34932@gvr.gvr.org> <20011214135243.B64853@sunbay.com> <20011214125438.A35615@gvr.gvr.org> <20011214142928.A69958@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011214142928.A69958@sunbay.com>; from ru@FreeBSD.org on Fri, Dec 14, 2001 at 02:29:28PM +0200 X-URL: http://people.freebsd.org/~cjc/ Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Dec 14, 2001 at 02:29:28PM +0200, Ruslan Ermilov wrote: > On Fri, Dec 14, 2001 at 12:54:38PM +0100, Guido van Rooij wrote: > > On Fri, Dec 14, 2001 at 01:52:43PM +0200, Ruslan Ermilov wrote: > > > On Fri, Dec 14, 2001 at 11:57:11AM +0100, Guido van Rooij wrote: > > > > On Fri, Dec 14, 2001 at 12:58:21AM -0800, Ruslan Ermilov wrote: > > > > > ru 2001/12/14 00:58:21 PST > > > > > > > > > > Modified files: > > > > > etc/periodic/security 550.ipfwlimit 650.ip6fwlimit > > > > > Log: > > > > > Work around the bugfeature of test(1). > > > > > > > > > > PR: bin/32822 > > > > > > > > > > > > If I run this: > > > > if [ 0 -eq 0 -a "" -ne 1 ]; > > > > then echo foo > > > > fi > > > > then it works. Isn't the real problem that "${IPFW_LOG_LIMIT}" gets lost > > > > somehow? > > > > > > > Nope, try this: > > > > > > FOO= > > > if [ 0 -eq 1 -a ${FOO} -ne 1 ]; then > > > echo OK > > > fi > > > > > > An alternate solution would be to write: > > > > > > if [ 0 -eq 1 -a "${FOO}" -ne 1 ]; then > > > > But that is what was in /etc/security.. So why did it fail? > > > Now I feel really confused. I could reproduce this at the > morning, but couldn't after reading your mail. Fortunately, > I've figured what's different: > > $ /STABLE/bin/[ "" -eq 0 ] > $ /CURRENT/bin/[ "" -eq 0 ] > [: : out of range > > I'll investigate what's wrong with -current's /bin/[ shortly > and will back my (not actually relevant) changes out. Isn't test(1) now a sh(1) builtin on CURRENT? I was wondering why this "bug" was never seen in STABLE when the code is identical. -- "It's always funny until someone gets hurt. Then it's hilarious." Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message