From owner-svn-src-head@freebsd.org Fri Aug 3 19:40:28 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3349A104DCDA; Fri, 3 Aug 2018 19:40:28 +0000 (UTC) (envelope-from dab0816@gmail.com) Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A9316720F4; Fri, 3 Aug 2018 19:40:27 +0000 (UTC) (envelope-from dab0816@gmail.com) Received: by mail-it0-x22a.google.com with SMTP id s7-v6so9806784itb.4; Fri, 03 Aug 2018 12:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=nnpo7tvcPhTnwCjy+no0C58dPtLPteOSPTz374MNkDo=; b=OcP8DRP082KaIXeBHzpUdbHBXi1HbzRFMcHd2PosDgXF2NX7GPzAYpEEzehZlrZVSW mdV+SF8oeiVYp4IJDIaec4VFrL0U6ZHO5SdRLwIqUft5DJw33egIz0uE10cSTDplyYHw Uzik2sU/HVJLdcRc5PtWuwy4wJ+zSsQD80QZRG12ptb+FBfaBMmStsKtkP+3BZaU+m/d UfDdFByos2mvOAb6Np+dhSz0iAVu3Oy3S42mUBgZ9mDWsnrSFiNasstE6LEihVMduARP ufqyZS2eAjS0rJrBOb6UTq93IZ/vtPyg7XHLtjnrId+PFOXiZYT/1ZmhNgTT9XNiwLkr Pd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:references:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=nnpo7tvcPhTnwCjy+no0C58dPtLPteOSPTz374MNkDo=; b=okxXIJaH0r694dmAlOteXFsdWrHVQc3AAsjlUoze/RAgRlUIuGS3epXSVHqgZofDlZ 4VL+peMFQ/1FjBj/nu4LubWaLvOCdDHs86+PRrH0Qt27gQRvCkPCke/7pg/23ualHX/K mWL9E69gVSxsxGbnuiAsvZcMMfJgYtwf/iFC8ZIir7SKjggu1Do6oNJHY3CGvDEiddn1 +hvmXQNJEcUdYO/TFyqtNwTbRVIbTToDmeU/7MNVE8q52vUPgjkAzrbZj7IGoouovmdP lFg7wuy6nsNIFoeIAoVkr/URK1LoAeucqMUadkx1L4wA8sFnV16triK/EBMiWKEGXM+g XwwQ== X-Gm-Message-State: AOUpUlGie2zBVQo7k/0EUfP7uiy8MOPNhd/XixXvYV/Pxm2XjwEKW83W V/T1173WwHoFsAXJ7XhaNcu5nfEa X-Google-Smtp-Source: AAOMgpdDArnUjm2l3wzPb/sqboLjPASBzsnbO+Bo/SJkAtoo+Ol+XrPC0gH2+g09qcFiL97eAElTjw== X-Received: by 2002:a24:d681:: with SMTP id o123-v6mr7699063itg.115.1533325226956; Fri, 03 Aug 2018 12:40:26 -0700 (PDT) Received: from dab-xps-13-9370.localdomain ([73.242.52.255]) by smtp.gmail.com with ESMTPSA id o18-v6sm394433ioa.83.2018.08.03.12.40.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Aug 2018 12:40:26 -0700 (PDT) Sender: David Bright From: "David A. Bright" X-Google-Original-From: "David A. Bright" Subject: Re: svn commit: r336905 - head/tests/sys/kqueue/libkqueue To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807301421.w6UELnWf076212@repo.freebsd.org> Openpgp: preference=signencrypt Autocrypt: addr=dab@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFgqQsIBCADfDUZ79qW2MKVRQl9l9zMYzppdHn+eS7KGjUP9hjmYUuX3vM0Sc5DlJ9Py 59Byucg8zo6eow1iv6NdiEPuUEYB2ujDP/kbmC397zEt6p9ldlL4PXXSJumpdZCzwz4ACYB5 ke7OCljNqbigzoZgX5DXjyjx87NfG6eWkbnEweDPmae7DGj5bwQmJPoTqvJR7Ot/R/73ix8l hph1vdl83Iqu+IDVdlXTI2Afz4UaCRdfDiXgMQIo/HABXJ90+TXG/vH37Jb0kBflql9sEaUs CcTvMrye0Wjgv3VSPZm3ZEgmR7UKR71p2MJVlVVZUH3FHQ2jDqKpCMi7F3ERlvRDktm/ABEB AAHNHkRhdmlkIEJyaWdodCA8ZGFiQGZyZWVic2Qub3JnPsLAfQQTAQoAJwUCWCpCwgIbAwUJ BaOagAULCQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRAzeMsxoQO+aqagCADDt4FbZBz3VFev TEtAjuyzCDPmPom1MBwsh6KB2J84wKOsXPmZ7vqaZ2G70fCPNowqmHq56cAbp0BD1Lf6gD+3 imeacKc/E6n+L49LOhOtQ8EUyHs/nAUmlE1PrOS1w5wmCgRjPXa5k+zxj/YMsAEFdMn6UzOl 5MIJN/zhBB5tU2bkP5hF4rVvpQ1zlnSldoBLfPlG/w1RzvOSJfunZUTSNVrKYlSjEQ7q56ud xKoLPEdr+X8kqwZilh5WBiTt7mMw7lrP6dMV/GGmDg893J6conQ1l2RN6Un1gKlc3rgdz3sh ncr786WF3cV2dFSIrO/Pn3iNRR3uJouRLdLhU0kMzsBNBFgqQsIBCAC5ABwcVerpyp5NzHBD FSbxEyPab6HFH1E4zksEGyeypU8UW5acc2ko5Ovz7CE0n21uhBtIt/Lz5Koxz0LSqqnk9jIQ L/4XVvne+8YnT+Tf9DZv9We5K0tFit/DFgCzIpxacoxLGBRNSkSzFrAepvVinTk905igdYZY fxtHrAREU4BdqBMQtbgGaewHtOLlRRr+N4wkAZlJLa7RaLn5s/EakpmCM1eR8z0fOBNJSXlW Ozqh1cvwWZ00qj0rYXwXu0fgzpREmJFS01GByFuB4xDyqfAoynxKNBJH/qAcJTp7jST8PLWe 3Tblm4acsIAPHUcABgMnZYdMQnSwwa9/W1DlABEBAAHCwGUEGAEKAA8FAlgqQsICGwwFCQWj moAACgkQM3jLMaEDvmp8hQgAzKTYmU2cf35NdrtT9C7jBDWSVSDdyKHYSAKoP+vAkC3A1HH6 wohE5JvOZ6245vgBQwFHvzh2v7jDUWmB3CrcSSMUoUIwl15mWlCdCy/C3SAknxQx+zHYmx9v uHPS1yF2l0KPS30Kc1le1GqVYi5wxnWPo+gE3MH4DDh5LdDExYveMuBgybdNxV8Qvr25UghJ HrQCT+FCISo0FActO1Z5HzdOKxQe6KTn+zKr4yKCOe4kb7GUaAX3Pt82J7bMtwRzAKLyjMJV QueL/cr+geerKKrd8FyVAgQMhdBYD3lyjK6nGssgr4Og9+QtsE2RAVH9qqhcF3kI7nxJ7EDb /d3xag== Message-ID: Date: Fri, 3 Aug 2018 14:40:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201807301421.w6UELnWf076212@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 19:40:28 -0000 On 07/30/2018 09:21 AM, David Bright wrote: > Author: dab > Date: Mon Jul 30 14:21:49 2018 > New Revision: 336905 > URL: https://svnweb.freebsd.org/changeset/base/336905 > > Log: > Correct possible misleading error message in kqtest. > > ian@ pointed out that in the test_abstime() function time(NULL) is > used twice; once in an "if" test and again in the enclosed error > message. If the true branch was taken and the process got preempted > before the second time(NULL) call, by the time the error message was > generated enough time could have elapsed that the message could claim > that the event came "too early" but print an event time that was after > the expected timeout. Correct by making the time(NULL) call only once > and using that returned time in both the "if" test and the error > message. > > Reported by: ian@ > MFC after: 4 days > X-MFC-with: r336761, r336781, r336802 It turns out that this won't be MFC'd as the change doesn't apply to stable/11 or stable/10. The particular test corrected by this change doesn't exist in those branches. -- David Bright dab@FreeBSD.org