From owner-svn-ports-head@FreeBSD.ORG Mon Mar 24 11:48:44 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7C345974; Mon, 24 Mar 2014 11:48:44 +0000 (UTC) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id 72B208C9; Mon, 24 Mar 2014 11:48:43 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AkkIAL0aMFNbsUul/2dsb2JhbABZgwY7SwEBwnyBFBd0giUBAQEEOhwjEAsUBAklDyoeBhMJh3QBCM11F456B4Q4BJhJgTOQf4MuPA Received: from 165.75-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.75.165]) by relay.skynet.be with ESMTP; 24 Mar 2014 12:48:35 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s2OBmYix009529; Mon, 24 Mar 2014 12:48:34 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Mon, 24 Mar 2014 12:48:33 +0100 From: Tijl Coosemans To: Tijl Coosemans Subject: Re: svn commit: r347897 - head/devel/git Message-ID: <20140324124833.16490bde@kalimero.tijl.coosemans.org> In-Reply-To: <20140312175955.7dbc48a3@kalimero.tijl.coosemans.org> References: <201403111758.s2BHwmaJ008196@svn.freebsd.org> <20140312124838.4e7fcdea@kalimero.tijl.coosemans.org> <6405D0DB0BBE9214BFFFE025@ogg.in.absolight.net> <20140312175955.7dbc48a3@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Mar 2014 11:48:44 -0000 On Wed, 12 Mar 2014 17:59:55 +0100 Tijl Coosemans wrote: > On Wed, 12 Mar 2014 13:39:21 +0100 Mathieu Arnold wrote: >>+--On 12 mars 2014 12:48:38 +0100 Tijl Coosemans wrote: >>| On Wed, 12 Mar 2014 11:09:02 +0100 Mathieu Arnold wrote: >>|>+--On 11 mars 2014 17:58:48 +0000 Tijl Coosemans wrote: >>|>| Author: tijl >>|>| Date: Tue Mar 11 17:58:47 2014 >>|>| New Revision: 347897 >>|>| URL: http://svnweb.freebsd.org/changeset/ports/347897 >>|>| QAT: https://qat.redports.org/buildarchive/r347897/ >>|>| >>|>| Log: >>|>| Prevent detection of libcharset.h from converters/libiconv. >>|>| >>|>| This forces git to use nl_langinfo() from libc instead of >>|>| locale_charset() from libiconv. (The latter is practically an alias >>|>| for the first.) >>|> >>|> This need a PORTREVISION bump, doesn't it ? >>| >>| I decided not to bump it, but it is an edge case. This commit fixes >>| a build error on FreeBSD 10 with libiconv installed. When libiconv >>| is not installed it does not change anything. On FreeBSD 8 and 9 it >>| does change git to use nl_langinfo() instead of locale_charset() but >>| these functions are the same and git still links with libiconv for >>| other functions. So the dependencies stay the same, pkg-plist stays >>| the same and the overall functionality stays the same. >> >> Well, to quote the porter's handbook[1]: >> >> PORTREVISION should be increased each time a change is made to the port >> that changes the generated package in any way. That includes changes that >> only affect a package built with non-default options. >> >> If it's only a build fix, that is, there were no packages with the same >> version before, it's ok not to bump it, but if it changes the package, any >> package, it has to be bumped. >> >> 1: >> > > Yes I know, but that rule is too simple in this case. There's no benefit > to bump the version here. Git called a() which returns b() and now git > calls b() directly. This makes no difference to users and it makes no > difference to other ports/packages. ...until someone removes locale_charset from libiconv that is. From now on always PORTREVISION bump.