Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Nov 2003 12:42:39 +0100
From:      Gary Jennejohn <garyj@jennejohn.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Seigo Tanimura <tanimura@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/coda coda_psdev.c src/sys/dev/aac aac.c src/sys/dev/bktr bktr_core.c src/sys/dev/firewire firewire.c src/sys/dev/kbd kbd.c src/sys/dev/nmdm nmdm.c src/sys/dev/random randomdev.c ... 
Message-ID:  <200311101142.hAABgdGg016357@peedub.jennejohn.org>
In-Reply-To: Message from John Baldwin <jhb@FreeBSD.org>  <XFMail.20031109194035.jhb@FreeBSD.org> 

next in thread | previous in thread | raw e-mail | index | archive | help

John Baldwin writes:
> 
> On 09-Nov-2003 Seigo Tanimura wrote:
> > tanimura    2003/11/09 01:17:26 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/cam/scsi         scsi_target.c 
> >     sys/coda             coda_psdev.c 
> >     sys/dev/aac          aac.c 
> >     sys/dev/bktr         bktr_core.c 
> >     sys/dev/firewire     firewire.c 
> >     sys/dev/kbd          kbd.c 
> >     sys/dev/nmdm         nmdm.c 
> >     sys/dev/random       randomdev.c 
> >     sys/dev/sab          sab.c 
> >     sys/dev/snp          snp.c 
> >     sys/dev/sound/midi   midibuf.c 
> >     sys/dev/sound/pcm    channel.c 
> >     sys/dev/usb          ucom.c ugen.c uhid.c ums.c usb.c 
> >     sys/dev/zs           zs.c 
> >     sys/i386/bios        apm.c 
> >     sys/i386/isa         asc.c cx.c istallion.c mse.c spic.c 
> >                          stallion.c 
> >     sys/i4b/driver       i4b_rbch.c i4b_tel.c 
> >     sys/i4b/layer4       i4b_i4bdrv.c 
> >     sys/isa              psm.c 
> >     sys/kern             kern_condvar.c kern_event.c subr_log.c 
> >                          sys_generic.c sys_pipe.c tty.c tty_pty.c 
> >                          uipc_socket.c uipc_socket2.c vfs_subr.c 
> >     sys/net              bpf.c if_tap.c if_tun.c 
> >     sys/pc98/pc98        mse.c 
> >     sys/pccard           mecia.c pccard.c pcic.c 
> >     sys/sys              condvar.h selinfo.h 
> >   Log:
> >   - Implement selwakeuppri() which allows raising the priority of a
> >     thread being waken up.  The thread waken up can run at a priority as
> >     high as after tsleep().
> >   
> >   - Replace selwakeup()s with selwakeuppri()s and pass appropriate
> >     priorities.
> >   
> >   - Add cv_broadcastpri() which raises the priority of the broadcast
> >     threads.  Used by selwakeuppri() if collision occurs.
> >   
> >   Not objected in:        -arch, -current
> 
> Sorry I didn't speak up on arch@, just too busy.  But, why do you need
> to bump up the priority of the thread you are waking up?
> 

Not to mention that this commit breaks building the i4b stuff because
TTIPRI is defined in <sys/tty.h> which is not (and should not be)
included by i4b. I have a patch to fix the breakage.

---
Gary Jennejohn / garyj[at]jennejohn.org gj[at]freebsd.org gj[at]denx.de



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311101142.hAABgdGg016357>