From owner-freebsd-arm@freebsd.org Tue Jun 21 17:33:23 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3B45AC5236; Tue, 21 Jun 2016 17:33:23 +0000 (UTC) (envelope-from paul@gromit.dlib.vt.edu) Received: from gromit.dlib.vt.edu (gromit.dlib.vt.edu [128.173.126.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gromit.dlib.vt.edu", Issuer "Chumby Certificate Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AB2F62EF9; Tue, 21 Jun 2016 17:33:23 +0000 (UTC) (envelope-from paul@gromit.dlib.vt.edu) Received: from mather.chumby.lan (c-71-63-91-41.hsd1.va.comcast.net [71.63.91.41]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by gromit.dlib.vt.edu (Postfix) with ESMTPSA id 7DA625C0; Tue, 21 Jun 2016 13:33:21 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: BBB (cpsw(4)) seems to be broken in the latest 11-current From: Paul Mather In-Reply-To: Date: Tue, 21 Jun 2016 13:33:20 -0400 Cc: Luiz Otavio O Souza , "freebsd-arm@freebsd.org" , FreeBSD Current , Maxim Sobolev Content-Transfer-Encoding: quoted-printable Message-Id: References: <83A18C0E-FA89-4009-A8D5-3185FB27A688@netgate.com> To: Keith White X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 17:33:23 -0000 On Jun 20, 2016, at 6:33 PM, Keith White wrote: > On Mon, 20 Jun 2016, Luiz Otavio O Souza wrote: >=20 >> On Sun, Jun 19, 2016 at 1:11 AM, Maxim Sobolev wrote: >>> Jim, some update from here. Running r283287 of the driver, I still = see the >>> same "watchdog timeout" messages, but they do not lead to the = interface >>> lockout. The traffic resumes momentarily. Which is probably why I = never paid >>> much attention to those warnings before. Therefore, I suspect that = the new >>> MAC code does not deal with watchdog-triggered interface reset as = good as >>> the old code. Does it give you any ideas about what could be wrong = there by >>> any chance? >>=20 >>=20 >> Hi Maxim, >>=20 >> My recent changes contributed somehow to expose the bug more = frequently. >>=20 >> There was a condition in tx packet reclamation where we aren't >> restarting the tx queue in one of the possible stall conditions. >>=20 >> Please try the attached patch and let me know if it works for you. >>=20 >> Luiz >=20 > Your patch fixes the problem for me. Thanks! >=20 > FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #0 r302028M: Mon = Jun 20 18:19:55 EDT 2016 = kwhite@freebsd11:/usr/obj/arm.armv6/usr/src/sys/BEAGLEBONE-LOCAL arm = armv6 >=20 > ...keith The patch also fixes the problem for me. FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #2 r302030M: Tue Jun = 21 10:20:59 EDT 2016 = pmather@beaglebone:/usr/obj/usr/src/sys/BEAGLEBONE-NO_WITNESS arm Cheers, Paul.