From owner-cvs-all Fri Jan 10 11:46:25 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAE0237B405 for ; Fri, 10 Jan 2003 11:46:21 -0800 (PST) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4390143E4A for ; Fri, 10 Jan 2003 11:46:21 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 4796 invoked from network); 10 Jan 2003 19:46:25 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 10 Jan 2003 19:46:25 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h0AJkCUT091008; Fri, 10 Jan 2003 14:46:13 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Fri, 10 Jan 2003 14:46:21 -0500 (EST) From: John Baldwin To: Nate Lawson Subject: Re: [src] cvs commit: src/lib/libdisk chunk.c create_chunk.c lib Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 10-Jan-2003 Nate Lawson wrote: > On Fri, 10 Jan 2003, John Baldwin wrote: >> Modified files: >> lib/libdisk chunk.c create_chunk.c libdisk.h >> Log: >> - Make New_Disk() non-static so it can be used in Create_Chunk_DWIM(). >> - In Create_Chunk_DWIM(), if there is a freebsd chunk that has no >> children chunks, then trying to add a child part chunk will fail even >> though there is free space. Handle this special case by adding an >> unused chunk the full size of the freebsd chunk as a child of the >> freebsd chunk before adding the new part chunk. This situation can >> happen when changing the type of an existing slice to be a FreeBSD >> slice type or when installing onto a blank disk on Alpha (which has >> no slices.) >> >> Reviewed by: phk >> MFC after: 2 days > > Great! Please update bin/24435 (yes, this has been around a shameful > amount of time) Hmm, didn't know this was present in 4.x as well. Doh. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message