Date: Mon, 25 Sep 2006 21:50:16 +0400 (MSD) From: Dmitry Morozovsky <marck@rinet.ru> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: stable@freebsd.org Subject: Re: chpass(1) patch for changing only crypted passwords Message-ID: <20060925214730.R752@woozle.rinet.ru> In-Reply-To: <868xk8tjfy.fsf@dwp.des.no> References: <20060925114102.F79983@woozle.rinet.ru> <868xk8tjfy.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 25 Sep 2006, Dag-Erling Sm?rgrav wrote: DS> Dmitry Morozovsky <marck@rinet.ru> writes: DS> > chpass is a bit broken since chpass.c:1.23 - it uses pw_equal which DS> > does not check crypted password field; so, you can not change _only_ DS> > crypt pass with chpass. Attached patch fixes this. DS> DS> Looks fine to me, feel free to commit. Done, thanks. BTW, a question inspired by ru@: why pw_equal() skips password field? Its interface is unpublished, and the only consumers are marck@woozle:/lh/src.current> grep -Rl pw_equal . ./lib/libutil/libutil.h ./lib/libutil/pw_util.c ./release/picobsd/tinyware/passwd/pw_copy.c ./usr.bin/chpass/chpass.c and tyniware is false alarm ;) Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060925214730.R752>