From owner-svn-src-all@FreeBSD.ORG  Thu Nov 11 16:53:25 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AEA5F1065672;
	Thu, 11 Nov 2010 16:53:25 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D76E8FC12;
	Thu, 11 Nov 2010 16:53:25 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oABGrPRD075920;
	Thu, 11 Nov 2010 16:53:25 GMT (envelope-from ed@svn.freebsd.org)
Received: (from ed@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id oABGrPc8075917;
	Thu, 11 Nov 2010 16:53:25 GMT (envelope-from ed@svn.freebsd.org)
Message-Id: <201011111653.oABGrPc8075917@svn.freebsd.org>
From: Ed Schouten <ed@FreeBSD.org>
Date: Thu, 11 Nov 2010 16:53:25 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r215129 - in head: contrib/compiler-rt/lib
	lib/libcompiler_rt
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Nov 2010 16:53:25 -0000

Author: ed
Date: Thu Nov 11 16:53:25 2010
New Revision: 215129
URL: http://svn.freebsd.org/changeset/base/215129

Log:
  Set symbol visibility to hidden.
  
  Not doing so may cause all sorts of random libraries to expose
  libcompiler_rt's functions, which should of course not be done.
  
  Discussed with:	kan, kib

Modified:
  head/contrib/compiler-rt/lib/assembly.h
  head/lib/libcompiler_rt/Makefile

Modified: head/contrib/compiler-rt/lib/assembly.h
==============================================================================
--- head/contrib/compiler-rt/lib/assembly.h	Thu Nov 11 16:06:47 2010	(r215128)
+++ head/contrib/compiler-rt/lib/assembly.h	Thu Nov 11 16:53:25 2010	(r215129)
@@ -33,7 +33,7 @@
 #ifdef VISIBILITY_HIDDEN
 #define DEFINE_COMPILERRT_FUNCTION(name) \
   .globl SYMBOL_NAME(name) SEPARATOR     \
-  .private_extern SYMBOL_NAME(name) SEPARATOR    \
+  .hidden SYMBOL_NAME(name) SEPARATOR    \
   SYMBOL_NAME(name):
 #else
 #define DEFINE_COMPILERRT_FUNCTION(name) \
@@ -43,12 +43,12 @@
 
 #define DEFINE_COMPILERRT_PRIVATE_FUNCTION(name) \
   .globl SYMBOL_NAME(name) SEPARATOR             \
-  .private_extern SYMBOL_NAME(name) SEPARATOR    \
+  .hidden SYMBOL_NAME(name) SEPARATOR    \
   SYMBOL_NAME(name):
 
 #define DEFINE_COMPILERRT_PRIVATE_FUNCTION_UNMANGLED(name) \
   .globl name SEPARATOR             \
-  .private_extern name SEPARATOR    \
+  .hidden name SEPARATOR    \
   name:
 
 #endif /* COMPILERRT_ASSEMBLY_H */

Modified: head/lib/libcompiler_rt/Makefile
==============================================================================
--- head/lib/libcompiler_rt/Makefile	Thu Nov 11 16:06:47 2010	(r215128)
+++ head/lib/libcompiler_rt/Makefile	Thu Nov 11 16:53:25 2010	(r215129)
@@ -6,7 +6,7 @@ LIB=	compiler_rt
 NO_PIC=
 WARNS?=	2
 
-CFLAGS+=${PICFLAG}
+CFLAGS+=${PICFLAG} -fvisibility=hidden -DVISIBILITY_HIDDEN
 
 .if ${MACHINE_CPUARCH} == "amd64"
 CRTARCH=x86_64