From owner-cvs-all Sat Aug 11 13:47:37 2001 Delivered-To: cvs-all@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 0967D37B40C; Sat, 11 Aug 2001 13:47:30 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.4/8.11.2) id f7BKlT419906; Sat, 11 Aug 2001 13:47:29 -0700 (PDT) (envelope-from dillon) Date: Sat, 11 Aug 2001 13:47:29 -0700 (PDT) From: Matt Dillon Message-Id: <200108112047.f7BKlT419906@earth.backplane.com> To: Mike Barcroft Cc: Josef Karthauser , Eivind Eklund , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: CVS patch implements update -T (was Re: Remote CVS/Template) References: <3B4F1FCD.7F2D4842@FreeBSD.org> <20010713120140Q.jkh@osd.bsdi.com> <20010713211017.A57434@heechee.tobez.org> <20010713123241X.jkh@osd.bsdi.com> <200107132214.f6DMET571067@earth.backplane.com> <20010715143503.A10888@FreeBSD.org> <20010810133132.G624@tao.org.uk> <200108111945.f7BJjIo19532@earth.backplane.com> <20010811170257.B23231@coffee.q9media.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :Is there a reason why you aren't checking the result of asprintf(3) :for memory allocation errors? I believe your other patch suffers :from a similar problem with strdup(3). Other than that, the changes :look good. : :BTW, great article on DaemonNews this month. : :Best regards, :Mike Barcroft I suppose I could add a check. I usually have a 'safe_asprintf' routine that I use for my own work. I NULL-out the pointers before-hand so the worse that will happen is that the program will seg fault. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message