From owner-svn-ports-all@FreeBSD.ORG Fri Jan 25 18:29:02 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 73E49BD3 for ; Fri, 25 Jan 2013 18:29:02 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx1.freebsd.org (Postfix) with ESMTP id 3055AF4E for ; Fri, 25 Jan 2013 18:29:01 +0000 (UTC) Received: by mail-vc0-f175.google.com with SMTP id fw7so499088vcb.6 for ; Fri, 25 Jan 2013 10:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=qsbu/hqigkexN+tARAC/Q/ijNVwl7fXip6ZoPdw6yF4=; b=MEMyCCzYmfaTpT3YLRJRr7mVl9Coc8PFssuPeA9yYbjqmt3e7g639jokSju0YNOJJ8 ab5fHNQqZxF/YOwmCxtkf2lhX9YSJNDKZhRZLEBk7rFqFege0XiPeCrQBJGWGhR+PcoF A9snuAhjpEpG8M/rbPGfDaTW2LEKXlD4W587w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=qsbu/hqigkexN+tARAC/Q/ijNVwl7fXip6ZoPdw6yF4=; b=OF5o4PquahShhpgQnMiwe5elKbi2yJQo0Ex1g0xmy2F7RPmYsp+lVU7Oz/ZSavMq0k K6B5k/KyIHvcb++SG3vERA7nyRblQVweFv2YbJG8IqNQuS+u4YwXeqy4d4vofDQP+Ot2 aeF0mW1IMZZTTQTtJVbds9iTpgVRBqiSus4ZIPN+tGZ0VCaPyqTwb/W5eMkMghCYi/JM k/0LRRkw1PYNkdKuD3LzxW5ClBc4ZwDX7Fn1E+9jq9cG8//mSGJmv+q5ivcEYTqnQqpM aDDL2LzZ0yOuvF5kkeiyiNKGIt3y7cuxqYjk7ZxxHa6fVq3LTEFBXNn7xIy8t/EsXPs4 uDkQ== X-Received: by 10.220.150.136 with SMTP id y8mr6977824vcv.34.1359138535415; Fri, 25 Jan 2013 10:28:55 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.220.195.70 with HTTP; Fri, 25 Jan 2013 10:28:25 -0800 (PST) In-Reply-To: <20130125165217.GE1328@glenbarber.us> References: <201301250435.r0P4ZoJO019936@svn.freebsd.org> <20130125.133855.326417115472002995.hrs@allbsd.org> <20130125165217.GE1328@glenbarber.us> From: Eitan Adler Date: Fri, 25 Jan 2013 13:28:25 -0500 X-Google-Sender-Auth: lT1iUOe_NKbGNeqPBx73KicM7T8 Message-ID: Subject: Re: svn commit: r310959 - head/textproc/docproj To: Glen Barber Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnuXNzzGu3s/HBChzHYq7ayR1VZ1ZEjt5hsCc6E4uD/R5Y0Y9nBzGFAJnCUPu+YkG2FVEny Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Hiroki Sato , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2013 18:29:02 -0000 On 25 January 2013 11:52, Glen Barber wrote: > On Fri, Jan 25, 2013 at 11:38:45AM -0500, Eitan Adler wrote: >> > Please bump PORTREVISION. >> >> This is/was not required because the default options did not change, >> so the package did not change. >> >> In addition an optional dependency was not changed so a gratuitous >> bump isn't useful here. > > Both of these are wrong. There was a default option and dependency > change. An optional dependency was *added* - it did not *change*. The point of PORTREVISION is for - the package building cluster (when the defaults change) - the user that builds from ports and needs to know that a port must be rebuilt. when an otptional dep is added neither of these conditions apply. This is a moot point because I missed with unusual location of the OPTIONS_DEFAULT. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams