Date: Fri, 25 Jan 2013 13:28:25 -0500 From: Eitan Adler <eadler@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Hiroki Sato <hrs@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r310959 - head/textproc/docproj Message-ID: <CAF6rxgkLXdg9kcwT0zeOTcL=XiSRhTXJn_kao-xCM_Bm2O3zdg@mail.gmail.com> In-Reply-To: <20130125165217.GE1328@glenbarber.us> References: <201301250435.r0P4ZoJO019936@svn.freebsd.org> <20130125.133855.326417115472002995.hrs@allbsd.org> <CAF6rxgmjqK9XwbRvNRDe4PVUZxn3qtUOqg6qRO7pjV5yHHnYLA@mail.gmail.com> <20130125165217.GE1328@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 January 2013 11:52, Glen Barber <gjb@freebsd.org> wrote: > On Fri, Jan 25, 2013 at 11:38:45AM -0500, Eitan Adler wrote: >> > Please bump PORTREVISION. >> >> This is/was not required because the default options did not change, >> so the package did not change. >> >> In addition an optional dependency was not changed so a gratuitous >> bump isn't useful here. > > Both of these are wrong. There was a default option and dependency > change. An optional dependency was *added* - it did not *change*. The point of PORTREVISION is for - the package building cluster (when the defaults change) - the user that builds from ports and needs to know that a port must be rebuilt. when an otptional dep is added neither of these conditions apply. This is a moot point because I missed with unusual location of the OPTIONS_DEFAULT. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkLXdg9kcwT0zeOTcL=XiSRhTXJn_kao-xCM_Bm2O3zdg>